Closed Bug 962645 Opened 11 years ago Closed 10 years ago

Action chains only handle one press->release chain

Categories

(Remote Protocol :: Marionette, defect, P2)

defect

Tracking

(firefox31 wontfix, firefox32 fixed, firefox33 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
mozilla33
Tracking Status
firefox31 --- wontfix
firefox32 --- fixed
firefox33 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: mdas, Assigned: TYLin)

References

Details

(Keywords: pi-marionette-goal, pi-marionette-spec, pi-marionette-userinput)

Attachments

(1 file)

We originally designed Actions to be one press->release chain to symbolize a single gesture, but I realize it may be useful to enable chaining of multiple, sequential actions. Say I want to do something like tap an element, and after 250 *server-side* ms, I want to tap it again. There is no way to do this in Marionette, since Actions only allow you one press->release chain. If I do something like: action.press(el).release().wait(0.250).press(el).release() Then I get "MarionetteException: Element has not been pressed", which fires thanks to the wait() (after the release() is called, it clears the current touchId and that triggers https://mxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-listener.js#934 to be true). It seems something like this would be useful so we don't have to rely on client side sleeps/waits, and it will avoid the case of high latency between client/server between actions. Dburns, what thinks you?
Flags: needinfo?(dburns)
Seems like an oversight on our part. > action.press(el).release().wait(0.250).press(el).release() should be supported
Flags: needinfo?(dburns)
Whiteboard: [touch]
Priority: -- → P2
Whiteboard: [touch]
wait() before press() should not raise "MarionetteException: Element has not been pressed." Try opt (Mnw, Gu): https://tbpl.mozilla.org/?tree=Try&rev=79e6a2aaaecf Try debug (Mn): https://tbpl.mozilla.org/?tree=Try&rev=acd87bb97245
Attachment #8439077 - Flags: review?(mdas)
Comment on attachment 8439077 [details] [diff] [review] Support wait between press->release action chain (v1) Review of attachment 8439077 [details] [diff] [review]: ----------------------------------------------------------------- Works perfectly, thanks for the patch!
Attachment #8439077 - Flags: review?(mdas) → review+
Malini, thanks for the review!
Assignee: nobody → tlin
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Blocks: 1020261
Blocks: 1028640
status-b2g-v2.0: --- → ?
blocking-b2g: --- → 2.0?
Causing test failures on Aurora in https://bugzilla.mozilla.org/show_bug.cgi?id=1028640
Clearing nom - we don't need to nom the Marionette failure here, just add a=test only & get this landed on 2.0 if it's needed.
blocking-b2g: 2.0? → ---
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: