From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.3+) Gecko/20010821 Netscape6/6.1b1 BuildID: 20010821 When inserting an image and not putting in an Alternative Text, an error will come up, advising you to put in an alternative text. If you don't click ok and just go back to image properties and put in an Alternative text, then try to click ok to the error .. Composer will crash with this error . Module .... gkview.dll Reproducible: Always Steps to Reproduce: 1.Open new document 2.Choose image from toolbar. 3.insert image, do not put in an alternative text 4.click ok 5.do not click ok to the error you get advising you to put in an alternative text 6.click back to the image properties and insert an alternative text 7.click ok on image properties. Actual Results: You will see that composer will Crash. Expected Results: Composer not to crash

Is this all platforms or Windows-specific? Reassign to cmanske since it was reported on Windows.

I will try Mac.

good catch ! Stack Trace nsViewManager::ProcessPendingUpdates [d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp, line 1636] nsViewManager::FlushPendingInvalidates [d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp, line 3827] nsViewManager::ProcessInvalidateEvent [d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp, line 3835] nsInvalidateEvent::HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp, line 145] PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 591] PL_ProcessPendingEvents [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 524] _md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 1072]

on Mac its not an issue cause its a modal dialog. yup its a charleu issue.

Dcone fixed one scenario of this same crasher in bug 94546. You might want to take a look there.

cc: Dcone, any ideas on this Don? I know its not your area, but you fixed a similar bug like this.

This sucks! Did we make a change in the modality of message dialogs? This is a potenital problem in all of our error-reporting dialogs.

Ok, so we are now doing modal windows correctly, but error message dialogs in Composer were setting the parent window to be the editor content instead of the calling dialog. Easy to fix.

The first patch is the minimum fix to correct all Composer dialogs that put up error dialogs. These were formerly using the implementations in C++ that were not setting the correct parent window. Note that you can crash composer in a large number of places by simply clicking on the parent dialog (when an error message is displayed) and click on the Cancel button. So this must be fixed! If we don't have an interface freeze issues, I strongly suggest that we also remove the methods "ConfirmWithTitle" and "AlertWithTitle" from the editorshell interface. (Note that we implemented those a very long time ago because the nsIPromptService was not adequate at the time.) Anyone who calls these methods from a window other than the Composer editor content window will risk introducing a crash bug. The nsIPromptService methods are very robust now and should be used instead.

r=brade for both patches; if 2nd patch isn't permitted, I think we should minimally remove all of the code in patch #2 and then return not implemented error

I'm very happy to see this disappear from C++ in nsEditorShell. Make sure you grep for other potential JS callers. sr=sfraser

bah mid-air with sfraser ... sr=kin@netscape.com I'm ok with the removing the alert/confirmation methods from nsIEditorShell, just make sure you find all instances and change them.

The attached patches fix all calls to the methods being removed. I did a clobber build and test all Composer UI.

a=asa on behalf of drivers.

both patches checked in

Adding topcrash keyword and Trunk [@ nsViewManager::ProcessPendingUpdates] to summary for tracking. This *was* a topcrasher according to recent MozillaTrunk Talkback data. NOTE: Although the stack signature (and stack trace) is the same as the one reported in bug 94546, this is a unique case and should not be dupped to that bug.

Sorry, I'm reopening this bug. The fix went in on 8/24, but Talkback is showing a lot of crashes after that date. Here are a few recent entries with helpful user comments: nsViewManager::ProcessPendingUpdates cfe38f7e http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/view/src/nsViewManager.cpp line 1638 Build: 2001082805 CrashDate: 2001-08-29 UptimeMinutes: 1 Total: 105 OS: Windows 98 4.10 build 67766446 Detailed : http://climate/reports/incidenttemplate.cfm?bbid=34696599 StackTrace: http://climate/reports/singleincidentinfo.cfm?dynamicBBID=34696599 (34696599) Comments: After clicking ok on the image properties window in composer after I inserted a javascript event I got this error message. nsViewManager::ProcessPendingUpdates b446d75b http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/view/src/nsViewManager.cpp line 1638 Build: 2001082805 CrashDate: 2001-08-29 UptimeMinutes: 103 Total: 103 OS: Windows 98 4.10 build 67766446 Detailed : http://climate/reports/incidenttemplate.cfm?bbid=34696500 StackTrace: http://climate/reports/singleincidentinfo.cfm?dynamicBBID=34696500 (34696500) Comments: I clicked ok on the image properties window while in composer and got this illegal operation nsViewManager::ProcessPendingUpdates 75904c2c http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/view/src/nsViewManager.cpp line 1638 Build: 2001082706 CrashDate: 2001-08-28 UptimeMinutes: 243 Total: 243 OS: Windows 98 4.10 build 67766222 Detailed : http://climate/reports/incidenttemplate.cfm?bbid=34632132 StackTrace: http://climate/reports/singleincidentinfo.cfm?dynamicBBID=34632132 (34632132) URL: my.netscape.com (34632132) Comments: canceld a save file as dialog nsViewManager::ProcessPendingUpdates 1d3e7a34 http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/view/src/nsViewManager.cpp line 1636 Build: 2001082610 CrashDate: 2001-08-28 UptimeMinutes: 259 Total: 259 OS: Windows NT 5.0 build 2195 Detailed : http://climate/reports/incidenttemplate.cfm?bbid=34619276 StackTrace: http://climate/reports/singleincidentinfo.cfm?dynamicBBID=34619276 (34619276) Comments: After a download I pressed the "Reveal location" button and while the application was lauching the Windows Explore I pressed the "Close" button on the "Save as" dialog itself.And Mozilla crashed!! nsViewManager::ProcessPendingUpdates f518efc2 http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/view/src/nsViewManager.cpp line 1638 Build: 2001082706 CrashDate: 2001-08-27 UptimeMinutes: 198 Total: 198 OS: Windows 98 4.10 build 67766446 Detailed : http://climate/reports/incidenttemplate.cfm?bbid=34593480 StackTrace: http://climate/reports/singleincidentinfo.cfm?dynamicBBID=34593480 (34593480) Comments: The browser crashes in classic skin while saving the attachment.(commercial trunk: 2001-08-27-06-trunk) nsViewManager::ProcessPendingUpdates 0b91256a http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/view/src/nsViewManager.cpp line 1636 Build: 2001082511 CrashDate: 2001-08-27 UptimeMinutes: 0 Total: 394 OS: Windows 98 4.90 build 73010104 Detailed : http://climate/reports/incidenttemplate.cfm?bbid=34612493 StackTrace: http://climate/reports/singleincidentinfo.cfm?dynamicBBID=34612493 (34612493) Comments: deleting certificate that was imported. I was told in bug bug 94546 to log a new view system bug for this crash, but I found this bug...so either these new crashes are a view system issue, or this bug is actually a bigger problem than just the editor dialogs.

jpatel: please file as a new bug The Composer issue was fixed. The stack traces you are finding are not in Composer.

Verified on 8-30 build