Comment on attachment 8372754 [details] [diff] [review] Patch Review of attachment 8372754 [details] [diff] [review]: ----------------------------------------------------------------- Something didn't get qref'd.

Comment on attachment 8372756 [details] [diff] [review] Patch (qref'd) Review of attachment 8372756 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/customizableui/test/browser_938980_navbar_collapsed.js @@ +106,5 @@ > + } > + ok(CustomizableUI.inDefaultState, "Everything should be in its default state"); > + yield startCustomizing(); > + let resetButton = document.getElementById("customization-reset-button"); > + is(resetButton.disabled, true, "The reset button should be disabled when in defaul state"); s/defaul /default / @@ +114,5 @@ > + ok(!CustomizableUI.inDefaultState, "No longer in default state when the menubar is shown"); > + > + yield gCustomizeMode.reset(); > + > + is(resetButton.disabled, true, "The reset button should be disabled when in defaul state"); ditto

Comment on attachment 8372756 [details] [diff] [review] Patch (qref'd) [Approval Request Comment] Bug caused by (feature/regressing bug #): regression from bug 966599 User impact if declined: restore defaults button doesn't get enabled when it should Testing completed (on m-c, etc.): on m-c and includes a test Risk to taking this patch (and alternatives if risky): none String or IDL/UUID changes made by this patch: none note: needs to land on top of the patch for bug 966599