The address bar for about:accounts shows the generic web favicon icon instead of the browser that the about:home and about 1/3 of the other about pages show (I would open the can of work to suggest we do them too, but am mostly concerned about about:accounts). See attached screenshot.

about:accounts should be added to http://hg.mozilla.org/mozilla-central/annotate/d8d8fa98ee7d/browser/base/content/browser.js#l6421.

Converted the whitelist to a regex, iterating over a list feels bad here. A regex that is compiled once should be faster and we can completely skip this check for non-about: URIs, too. I also fixed about:sessionstore to be about:sessionrestore.

I wonder if the uri.schemeIs() call actually makes sense, just executing the regex should pretty much walk the string too and compare characters - and bail out if the prefix doesn't match.

Comment on attachment 8386522 [details] [diff] [review] 0001-Bug-970382-Add-about-accounts-to-the-list-of-chrome-.patch [Approval Request Comment] Bug caused by (feature/regressing bug #): ? User impact if declined: about:accounts seems less trustworthy. Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): Low risk. String or IDL/UUID changes made by this patch: None.