Closed Bug 970893 Opened 11 years ago Closed 7 years ago

The home gesture should not prevent taps at the bottom of the screen

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: etienne, Assigned: mikehenrty)

References

Details

(Whiteboard: [systemsfe][p=3])

We should at least forward events when the user taps on the bottom-panel. We already keep track of the distance [1] and we have a nice little helper to forward touch events in a APZC compliant way [2] so this should be straightforward enough :) [1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/home_gesture.js#L70 [2] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/touch_forwarder.js
I'll take this, I need to re-use this event forwarding for the new notifications too, so starting with this bug makes sense.
Assignee: nobody → mhenretty
Whiteboard: [systemsfe][p=3]
Hey Mike, I know there's a lot going on right now, but for my own dogfooding sanity I want to make sure you're not blocked by anything here :) The change in system/js/home_gesture.js should be pretty similar to what I did in statusbar.js [1] for the touchforwarder part. [1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/statusbar.js#L384-457
(In reply to Etienne Segonzac (:etienne) from comment #2) > I know there's a lot going on right now, but for my own dogfooding sanity I > want to make sure you're not blocked by anything here :) Hi Etienne, thanks for checking in! I am indeed not blocked, and have a work in progress for this. But currently I am working on a 1.3+. I should get back to this tomorrow, and I'll let you know if that's not the case. Speaking of this, I did have a question. I see you have two ways to fetch the current app iframe to forward events into. Is there a preferred method, or tradeoffs between the two? AppWindowManager.getActiveApp().iframe StackManager.getCurrent().iframe https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/statusbar.js#L404 https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/edge_swipe_detector.js#L118
(In reply to Michael Henretty [:mhenretty] from comment #3) > AppWindowManager.getActiveApp().iframe > StackManager.getCurrent().iframe > Small preference for the StackManager since it will soon give you the current _sheet_ as opposed to the active app (with no API change).
Thanks for the info Etienne! Unfortunately, I won't be able to get to this today, as a couple of 1.4 blockers came up in triage today that I will need to take a look at first.
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.