Closed Bug 97138 Opened 23 years ago Closed 23 years ago

Heights on tables, row groups, rows, cells do not work correctly

Categories

(Core :: Layout: Tables, defect, P2)

x86
Windows NT
defect

Tracking

()

RESOLVED FIXED
mozilla0.9.6

People

(Reporter: karnaze, Assigned: karnaze)

References

Details

(Keywords: testcase, Whiteboard: PATCH CANDIDATE_094)

Attachments

(4 files)

This is a meta bug that groups all bugs that deal with incorrect heights on tables, row groups, rows, cells.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.5
Depends on: 58402
Depends on: 51000
Depends on: 87982
Depends on: 30692
Depends on: 57300
Depends on: 88035
In the attachment, IE honors the row with height=400 when the table has height=200, but does not honor the 2nd row with height=80%. It seems to place the constraint that the sum of the percentage rows cannot exceed 100%, but places no constraint on pixel valued rows. Is this reasonable, or should the 2nd row with height=80% get a full 80% of the table height? If possible, I would like to avoid the complicated, ess-efficient balancing that goes on with columns where the table width constraint has the highest priority. It appears that IE has avoided it as well.
Depends on: 42543
Depends on: 32205, 55202
Depends on: 98196
Keywords: testcase
Attached patch patch to fix most cases (deleted) — Splinter Review
Keywords: patch
I think you need to initialize the new mBits in the root reflow state constructor, no? Also, mBits seems like a pretty ambiguous name, why not something more meaningful like mRefowFlags? Also, please indicate what testing you have done, which cases it fixes and which it does not fix. Thanks.
reassigning to m0.9.6
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Blocks: 32451
Keywords: patch
Whiteboard: PATCH
Need to change unsigned to PRUint16 in struct with bitfields (from alexsavulov, attinasi).
Comment on attachment 56516 [details] [diff] [review] more up to date patch with reviewer's suggestions sr=attinasi, r=alexsavulov
Attachment #56516 - Flags: superreview+
Attachment #56516 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Priority: -- → P2
Resolution: --- → FIXED
Whiteboard: PATCH → PATCH CANDIDATE_094
checked in
Blocks: 106795
This checkin caused bug 109043
Blocks: 32205
No longer depends on: 32205
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: