Closed
Bug 97138
Opened 23 years ago
Closed 23 years ago
Heights on tables, row groups, rows, cells do not work correctly
Categories
(Core :: Layout: Tables, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla0.9.6
People
(Reporter: karnaze, Assigned: karnaze)
References
Details
(Keywords: testcase, Whiteboard: PATCH CANDIDATE_094)
Attachments
(4 files)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
karnaze
:
review+
karnaze
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
This is a meta bug that groups all bugs that deal with incorrect heights on
tables, row groups, rows, cells.
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.5
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
In the attachment, IE honors the row with height=400 when the table has
height=200, but does not honor the 2nd row with height=80%. It seems to place
the constraint that the sum of the percentage rows cannot exceed 100%, but
places no constraint on pixel valued rows. Is this reasonable, or should the 2nd
row with height=80% get a full 80% of the table height? If possible, I would
like to avoid the complicated, ess-efficient balancing that goes on with columns
where the table width constraint has the highest priority. It appears that IE
has avoided it as well.
Assignee | ||
Updated•23 years ago
|
Assignee | ||
Comment 3•23 years ago
|
||
Comment 4•23 years ago
|
||
I think you need to initialize the new mBits in the root reflow state
constructor, no? Also, mBits seems like a pretty ambiguous name, why not
something more meaningful like mRefowFlags? Also, please indicate what testing
you have done, which cases it fixes and which it does not fix. Thanks.
Assignee | ||
Comment 5•23 years ago
|
||
reassigning to m0.9.6
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Assignee | ||
Comment 6•23 years ago
|
||
Need to change unsigned to PRUint16 in struct with bitfields (from alexsavulov,
attinasi).
Assignee | ||
Comment 7•23 years ago
|
||
Assignee | ||
Comment 8•23 years ago
|
||
Comment on attachment 56516 [details] [diff] [review]
more up to date patch with reviewer's suggestions
sr=attinasi, r=alexsavulov
Attachment #56516 -
Flags: superreview+
Attachment #56516 -
Flags: review+
Assignee | ||
Comment 9•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Priority: -- → P2
Resolution: --- → FIXED
Whiteboard: PATCH → PATCH CANDIDATE_094
Assignee | ||
Comment 10•23 years ago
|
||
checked in
Comment 11•23 years ago
|
||
This checkin caused bug 109043
Assignee | ||
Updated•22 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•