To avoid rebuilding translation units that declare functions etc. that take/return Telemetry::ID values, we can define it as a sized enum and then forward declare it. Doing this we can remove the actual inclusion of the generated enum header file from all but one .h file (accessible/src/base/Statistics.h -- that file is only included in a few cpp files though). That means when histograms get added/removed, we'll rebuild less.

So this helps a bit, but perhaps not as much as we'd like, as I mention in bug 968923 comment 35. Might still be worth the churn though. Will get Vladan to review if you think this is worthwhile, gps.

Comment on attachment 8382758 [details] [diff] [review] patch Review of attachment 8382758 [details] [diff] [review]: ----------------------------------------------------------------- I'm not a C++ guru and don't know enough to give adequate feedback for this patch.

We already use a sized enum for Telemetry::HistogramID. The code changes here would be bitrotted a lot. Heycam, is that something that you'd still want to pick up or can we close this?

I think we can close it.