Closed
Bug 981598
Opened 11 years ago
Closed 10 years ago
[System]: add RTL support to Time Picker
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Firefox OS Graveyard
Gaia::System
Tracking
(Not tracked)
VERIFIED
FIXED
2.1 S1 (1aug)
People
(Reporter: flod, Assigned: flod)
References
Details
(Whiteboard: [rtl-meta])
Attachments
(2 files)
Localizability of time picker in System has been improved in bug 932356, but it's still lacking proper RTL support.
Assignee | ||
Comment 1•11 years ago
|
||
Ahmed, is this something you can take a look into or have suggestions on what the expected behavior should be?
Some notes:
* bug 932356: the reference used to build the time picker is shortTimeFormat (/shared/date/date.properties), for ar this key is currently set to "%I:%M %p".
* bug 932270: this let locales translate AM/PM, but those strings are still missing from the Arabic localization.
I tried running a profile in Firefox and the time reel is just displayed like the English one.
Flags: needinfo?(nefzaoui.ahmed)
Comment 2•11 years ago
|
||
To answer the question of what do I think the behavior should be; Normally in RTL, AM/PM should be on the left.
And according to this attachement:
https://bug932356.bugzilla.mozilla.org/attachment.cgi?id=8384270
3rd screenshot on the left makes sense.
I will try and have a look at it tonight in a device and get back with feedback or a PR :)
Flags: needinfo?(nefzaoui.ahmed)
Assignee | ||
Comment 3•10 years ago
|
||
Ahmed, is this correct?
Attachment #8460957 -
Flags: feedback?(nefzaoui.ahmed)
Comment 4•10 years ago
|
||
Yes, it is! :)
Comment 5•10 years ago
|
||
Comment on attachment 8460957 [details]
ar.png
Only shifting the AM/PM label to the left.
Yes it is correct. :)
Attachment #8460957 -
Flags: feedback?(nefzaoui.ahmed) → feedback+
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8460986 -
Flags: review?(timdream)
Comment 7•10 years ago
|
||
Comment on attachment 8460986 [details]
Pull request on Github
Thanks for the patch!
Attachment #8460986 -
Flags: review?(timdream) → review+
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment 8•10 years ago
|
||
flod, tim, are the travis errors on https://travis-ci.org/mozilla-b2g/gaia/builds/30671392 are related to this patch (i guess no, but better ask :)
Assignee | ||
Comment 9•10 years ago
|
||
This patch changes the aspect of time picker only for RTL locales, so it's probably not part of any tests at the moment (RTL support is not great at the moment).
Comment 10•10 years ago
|
||
landed in master as https://github.com/mozilla-b2g/gaia/commit/ce38a85582b3fa09021e8c5b37394b543dd39890
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S1 (1aug)
Assignee | ||
Comment 11•10 years ago
|
||
Verified on flame
Gaia c8511217183ade630f5afa7698c04efef5c6806b
Gecko https://hg.mozilla.org/mozilla-central/rev/a4dcfbebcb58
BuildID 20140728040209
Version 34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•