Seen with mozilla 09/04 Windows, also seen a couple of days ago, is a regression: When clicking between newsgroups the view jumps back to unthreaded view. (both in modre How to reproduce: - Sign up to two newsgroups on news.mozilla.org. - Choose View->Sort by->Thread and View->Messages->Threads with unread for them. - Mark all messages as read with Shift-Ctrl-C in both groups - Now switch a couple of times between these groups (click on them) and you'll see that the View->Sort by jumps back to "Order received". If you change it back to "Thread" it will jump back to "Order received" everytime you visit that newsgroup. I tried a fresh profile and both modern/clasic theme. This is happening in both of them!

I've noticed this for quite a while in regular, non newsgroup mailboxes. It seems to happen randomly when a new message is downloaded. Essentially, the folder is set to a threaded view, but during downloading (provided the folder is NOT the current folder), it loses it. You notice before entering the box as the folder is no longer highlighted bold (indicating new message/s), but there is still a green arrow on the icon, implying unread mail.

Update: This happens only when you chose "Unread","View threads with unread", or "Watched threads with unread", it will *not* happen, when you simply chose threaded view and view "All".

This now seems to be happening much more frequently. (As of 20011125 WinME) It used to happen for me only randomly, but now it happens almost every time. I have my newsgroups set to Unread/Threaded. May also be related to bug 111895

carrying over the nsbeta1+ from bug 112004

*** Bug 112004 has been marked as a duplicate of this bug. ***

I see this too with 2002-02-20-16 on Linux. The sort order seams to be lost, occasionally, on switching between newsgroups.

This doesn't seem limited on NT. It seems to happen on Linux too. Platform ALL? I can reproduce *something similiar to this* 100% of the time, although I'm not sure if this relates exactly ... but it seems to be. Steps 1)Create a new profile or use a profile that doesn't have news.mozilla.org 2)Add news.mozilla.org as a news server 3)Choose Subscribe Groups, check netscape.test (probably doesn't matter which newsgroup) 4) Click ok 5) Right click on netscape.test and choose Mark newsgroup as read 6) Switch to something else 7) Switch back and mozilla has forgotten what the threading was! (the difference is that it's not exactly forgetting out of the blue) (you could probably use another server besides news.mozilla.org) I will follow up if i find anything else during my testing

here's a little variation which seems to be what this bug is about 1) subscribe to netscape.test 2) select all -> mark all as read (don't use mark newsgroup as read) 3) pick some other folder and come back to netscape.test -> view should still be threaded (if it's not. make it threaded. it shouldn't forget just yet. 4) pick any message(i picked a 3rd level message in a thread). compose a reply to that message. post it. 5) select View Threads with unread 6) select some other folder or anything 7) go back and you should now see the new message, but the Threading has disappeared i hope this is enough to track the bug down because it's quite annoying

Another symptom of this bug is that the "Threaded" menu item doesn't work when there are no items visible. Eg, to reproduce this, follow the examples already in this bug - note that "threaded" is not selected. Further, if you try and select "threaded", it has no effect - the menu still does not become checked. I have tracked this down to the nsMsgThreadedDBView::Sort() function. It short circuits when there are no visible items - meaning that the internal "threaded" flag is not set. Attaching a patch that solves this :) Also confirmed the bug and fix on Linux, so setting "OS" accordingly.

Set the internal flags, and save them away. Without the save, the flag would be set correctly (allowing the menu item to be checked), but was not remembered when moving away from the newsgroup then back to it.

moving to 1.0 but if we can get the patch in earlier, that works.

Comment on attachment 68855 [details] [diff] [review] Proposed patch Makes sense to me. Mark, I assume you have regression-tested the threadpane thorougly? r=hwaara

I have tested thoroughly - however, all I can say is that the rest of threading is just as broken with my patch as without it :) There seems to be a problem in that unchecking threaded view does not work - it always remains checked (and therefore threaded). I can not see a bug for this - am I just not looking hard enough? Either way, it is exactly the same with as without my patch. Apart from that, all other threading problems I see already have bugs.

Comment on attachment 69929 [details] [diff] [review] Updated patch against rev 1.37 of nsMsgThreadedDBView.cpp Old patch failed to cleanly update to rev 1.37 due to changes immediately after the block. Assuming last review still applies.

nsbeta1- per ADT triage, ->1.2, blocks 'miracle bug' 122274

Patch exists. Nominating for Mozilla 1.0.

Since no one seems to have bothered to ask for sr for the patch, I have taken the liberty of doing so.

Actually, I did email mscott, bienvenu and sspitzer for sr= on 2002-02-17 - but no one replied.

Comment on attachment 69929 [details] [diff] [review] Updated patch against rev 1.37 of nsMsgThreadedDBView.cpp this looks good, sr=sspitzer please make sure to test quick search and advanced search. there might be an optimization (to avoid calling SaveSortInfo()) by checking m_sortType != sortType, but we might need to take into account m_sortValid. I'm ok with keeping it simple and clean, like mark has it, and investigating the optimization later.

All search functionality seems to work fine. Will check in tomorrow - if the tree is not open by then will try drivers.

The tree is not opening till after 1.0 branches (see roadmap). So you'll need to ask drivers for 1.0 approval anyway (once 0.9.9 branches).

Comment on attachment 69929 [details] [diff] [review] Updated patch against rev 1.37 of nsMsgThreadedDBView.cpp a=blizzard on behalf of drivers for 0.9.9

Checking in nsMsgThreadedDBView.cpp; /cvsroot/mozilla/mailnews/base/src/nsMsgThreadedDBView.cpp,v <-- nsMsgThreadedDBView.cpp new revision: 1.38; previous revision: 1.37 done

Sorry, but I'm still seeing this. When downloading new headers (I have view->messages->unread set) often the newsgroup is unthreaded. The menu shows View->sort by->order received, but the icon at the top left of the message list shows threaded. Should I reopen this bug ? checkout finish: Thu Mar 7 13:00:17 GMT 2002 (straight CVS)

I have this problem in 0.9.9. View / Messages / Unread is set and so is View / Messages / Threaded and View / Sort by / Thread. When I enter a group, the unread messages are displayed. The messages look threaded. But View / Messages / Threaded changes the threading. I use RedHat 7.1 Linux on a PC.

edcjones@erols.com. you should download 1.0rc1, 'Threaded' has since been removed from View -> Messages since it was redundant. So setting Sort By Thread and selecting View -> Messages Threaded might not necessarily do what you expect.

Not seeing this with current branch builds: mac OS 10.1, linux rh6.2, win98. Will check trunk.

Not seeing on apr26trunk, linux rh6.2, mac OS 10.1