Closed
Bug 982835
Opened 11 years ago
Closed 11 years ago
[OSX] Bookmark item hover background color is wrong when subview opened in Panel UI
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 30
People
(Reporter: Gijs, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Keywords: regression, Whiteboard: [Australis:P3])
Attachments
(1 file)
(deleted),
patch
|
mikedeboer
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
This is because https://hg.mozilla.org/mozilla-central/rev/ccbe695b5f40#l6.12 made the toolbarbutton.bookmark-item rules more specific by adding :not(#bookmarks-menu-button), which means it now beats the .subviewbutton rule and so the toolbar hover style is applying instead of the panel one.
Assignee | ||
Updated•11 years ago
|
Summary: Bookmarks hover background color is wrong when in Panel UI → [OSX] Bookmark item hover background color is wrong when subview opened in Panel UI
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8390452 -
Flags: review?(mdeboer)
Comment 2•11 years ago
|
||
Comment on attachment 8390452 [details] [diff] [review]
Australis bookmark subview hover color is wrong when in main menu panel,
Review of attachment 8390452 [details] [diff] [review]:
-----------------------------------------------------------------
I like it! Thanks for fixing this.
Attachment #8390452 -
Flags: review?(mdeboer) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Whiteboard: [Australis:P3] → [Australis:P3][fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3][fixed-in-fx-team] → [Australis:P3]
Target Milestone: --- → Firefox 30
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 8390452 [details] [diff] [review]
Australis bookmark subview hover color is wrong when in main menu panel,
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis / bug 909349
User impact if declined: bookmark items in the menu have the wrong hover color
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none
Attachment #8390452 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
status-firefox29:
--- → affected
status-firefox30:
--- → fixed
Updated•11 years ago
|
Attachment #8390452 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 6•11 years ago
|
||
Updated•11 years ago
|
QA Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•