Closed
Bug 984630
Opened 11 years ago
Closed 11 years ago
socialapi buttons have no hover state, incorrect padding, etc on linux
Categories
(Firefox Graveyard :: SocialAPI, defect)
Tracking
(firefox28 unaffected, firefox29+ verified, firefox30+ verified, firefox31 verified)
VERIFIED
FIXED
Firefox 31
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
Details
Attachments
(1 file)
|
(deleted),
patch
|
Gijs
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
fx-team build from today looking to verify bug 984535, noticed lack of hover state for any socialapi buttons
|
Assignee | |
Updated•11 years ago
|
Summary: socialapi buttons have no hover state on linux → socialapi buttons have no hover state, incorrect padding, etc on linux
|
|
Assignee | |
Comment 1•11 years ago
|
||
This fixes a number of styling issues on linux, now hover and open states work, correct padding, which also happens to fix a hidden icon on the socialmarks button.
Assignee: nobody → mixedpuppy
Attachment #8393717 -
Flags: review?(gijskruitbosch+bugs)
|
||
Updated•11 years ago
|
Attachment #8393717 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
|
|
Assignee | |
Updated•11 years ago
|
status-firefox28:
--- → unaffected
status-firefox29:
--- → affected
status-firefox30:
--- → affected
status-firefox31:
--- → fixed
tracking-firefox29:
--- → ?
tracking-firefox30:
--- → ?
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8393717 [details] [diff] [review]
fix linux social button styling
[Approval Request Comment]
Bug caused by (feature/regressing bug #): australis
User impact if declined: incorrectly sized toolbar buttons, missing icons for socialmarks
Testing completed (on m-c, etc.): fx-team and m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none
Attachment #8393717 -
Flags: approval-mozilla-beta?
Attachment #8393717 -
Flags: approval-mozilla-aurora?
|
||
Updated•11 years ago
|
Attachment #8393717 -
Flags: approval-mozilla-beta?
Attachment #8393717 -
Flags: approval-mozilla-beta+
Attachment #8393717 -
Flags: approval-mozilla-aurora?
Attachment #8393717 -
Flags: approval-mozilla-aurora+
|
|
||
Updated•11 years ago
|
|
||
Comment 5•11 years ago
|
||
|
||
Comment 6•11 years ago
|
||
Verified as fixed using Firefox 29 beta 3, latest Aurora and latest Nightly on Ubuntu 12.04 32bit.
Status: RESOLVED → VERIFIED
Keywords: verifyme
|
||
Updated•6 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•