The push for bug 981166 was hitting intermittent packaging errors on Windows, so I had to touch CLOBBER when merging it around. https://hg.mozilla.org/integration/fx-team/pushloghtml?changeset=132db9edab95 https://tbpl.mozilla.org/php/getParsedLog.php?id=36612002&tree=Fx-Team make.py[6]: Entering directory 'c:\builds\moz2_slave\fx-team-w32-000000000000000000\build\obj-firefox\browser\branding\nightly\locales' make.py[6]: Leaving directory 'c:\builds\moz2_slave\fx-team-w32-000000000000000000\build\obj-firefox\browser\branding\nightly\locales' make.py[5]: Leaving directory 'c:\builds\moz2_slave\fx-team-w32-000000000000000000\build\obj-firefox\browser\locales\../../browser/branding/nightly/locales' c:\builds\moz2_slave\fx-team-w32-000000000000000000\build\toolkit\locales\l10n.mk:109:0$ rm -f -r c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/obj-firefox/browser/locales/../../dist/l10n-stage/firefox/uninstall; c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/obj-firefox/_virtualenv/Scripts/python.exe c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/config/nsinstall.py -D c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/obj-firefox/browser/locales/../../dist/l10n-stage/firefox/uninstall; cp ../installer/windows/l10ngen/helper.exe c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/obj-firefox/browser/locales/../../dist/l10n-stage/firefox/uninstall; rm -f c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/obj-firefox/browser/locales/../../dist/l10n-stage/setup.exe; cp ../installer/windows/l10ngen/setup.exe c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/obj-firefox/browser/locales/../../dist/l10n-stage; c:\builds\moz2_slave\fx-team-w32-000000000000000000\build\toolkit\locales\l10n.mk:114:0$ c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/obj-firefox/_virtualenv/Scripts/python.exe c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/toolkit/mozapps/installer/l10n-repack.py c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/obj-firefox/browser/locales/../../dist/l10n-stage/firefox ../../dist/xpi-stage/locale-x-test \ c:\builds\moz2_slave\fx-team-w32-000000000000000000\build\toolkit\locales\l10n.mk:114:0: command 'c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/obj-firefox/_virtualenv/Scripts/python.exe c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/toolkit/mozapps/installer/l10n-repack.py c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/obj-firefox/browser/locales/../../dist/l10n-stage/firefox ../../dist/xpi-stage/locale-x-test \ ' failed, return code 1 c:\builds\moz2_slave\fx-team-w32-000000000000000000\build\obj-firefox\browser\locales\Makefile:153:0: command 'C:/mozilla-build/python27/python.exe c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/build/pymake/pymake/../make.py repackage-zip \ AB_CD=x-test \ MOZ_PKG_FORMAT=SFX7Z \ ZIP_IN='c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/obj-firefox/browser/locales/../../dist/win32/en-US/Nightly Setup 31.0a1.exe' \ ZIP_OUT='c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/obj-firefox/browser/locales/../../dist/win32/x-test/Nightly Setup 31.0a1.exe' \ SFX_HEADER='c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/obj-firefox/browser/locales/../installer/windows/l10ngen/7zSD.sfx \ c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/browser/installer/windows/app.tag'' failed, return code 2 c:\builds\moz2_slave\fx-team-w32-000000000000000000\build\obj-firefox\browser\locales\Makefile:163:0: command 'C:/mozilla-build/python27/python.exe c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/build/pymake/pymake/../make.py repackage-win32-installer AB_CD=x-test WIN32_INSTALLER_IN='c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/obj-firefox/browser/locales/../../dist/win32/en-US/Nightly Setup 31.0a1.exe'' failed, return code 2 c:\builds\moz2_slave\fx-team-w32-000000000000000000\build\obj-firefox\browser\locales\Makefile:238:0: command 'C:/mozilla-build/python27/python.exe c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/build/pymake/pymake/../make.py installers-x-test L10NBASEDIR='c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/obj-firefox/browser/locales' LOCALE_MERGEDIR='c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/obj-firefox/browser/locales/mergedir'' failed, return code 2 c:\builds\moz2_slave\fx-team-w32-000000000000000000\build\browser\build.mk:42:0: command 'C:/mozilla-build/python27/python.exe c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/build/pymake/pymake/../make.py -C browser/locales l10n-check' failed, return code 2 Traceback (most recent call last): File "c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/toolkit/mozapps/installer/l10n-repack.py", line 48, in <module> main() File "c:/builds/moz2_slave/fx-team-w32-000000000000000000/build/toolkit/mozapps/installer/l10n-repack.py", line 44, in main l10n.repack(args.build, args.l10n, args.non_resource, NON_CHROME) File "c:\builds\moz2_slave\fx-team-w32-000000000000000000\build\python\mozbuild\mozpack\packager\l10n.py", line 172, in repack _repack(app_finder, l10n_finder, copier, formatter, non_chrome) File "c:\builds\moz2_slave\fx-team-w32-000000000000000000\build\python\mozbuild\mozpack\packager\l10n.py", line 83, in _repack for e in app.entries File "c:\builds\moz2_slave\fx-team-w32-000000000000000000\build\python\mozbuild\mozpack\packager\l10n.py", line 84, in <genexpr> if isinstance(e, ManifestEntryWithRelPath)) KeyError: 'metro' program finished with exit code 2

Without looking at the source, it appears to me like the packaging code doesn't handle deleted directories?

Smells like l10n-stage is not cleaned up or something.

We never shipped the metro support, closing!