Closed Bug 988144 Opened 11 years ago Closed 11 years ago

UITour: Highlight effects don't occur if a highlight is moved to a different target without calling hideHighlight

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 31
Tracking Status
firefox29 --- fixed
firefox30 --- fixed
firefox31 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

Details

(Whiteboard: [Australis:P5])

Attachments

(1 file)

There was nothing to trigger the effect again if the specified effect was the same as the current highlight. This is for the case where you simply want to move a highlight without calling hideHighlight in between. This was brought to my attention by :agibson. The workaround is to always call hideHighlight before a showHighlight so this is P5.
Attachment #8396926 - Flags: review?(bmcbride)
Comment on attachment 8396926 [details] [diff] [review] v.1 Set the effect to "none" and flush before setting an effect Review of attachment 8396926 [details] [diff] [review]: ----------------------------------------------------------------- Holy gaping hole in the web api, batman.
Attachment #8396926 - Flags: review?(bmcbride) → review+
Agreed, having to think about layout flushes as a web developer feels dirty to me.
Flags: in-testsuite+
Whiteboard: [Australis:P5] → [Australis:P5][fixed-in-fx-team]
Comment on attachment 8396926 [details] [diff] [review] v.1 Set the effect to "none" and flush before setting an effect [Approval Request Comment] Bug caused by (feature/regressing bug #): UITour initial effect implementation User impact if declined: a highlight animation may not occur following another highlight Testing completed (on m-c, etc.): Locally, m-c soon Risk to taking this patch (and alternatives if risky): Low risk 2 line fix to trigger the animation with a test String or IDL/UUID changes made by this patch: None
Attachment #8396926 - Flags: approval-mozilla-beta?
Attachment #8396926 - Flags: approval-mozilla-aurora?
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P5][fixed-in-fx-team] → [Australis:P5]
Target Milestone: --- → Firefox 31
Attachment #8396926 - Flags: approval-mozilla-beta?
Attachment #8396926 - Flags: approval-mozilla-beta+
Attachment #8396926 - Flags: approval-mozilla-aurora?
Attachment #8396926 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: