Closed
Bug 988144
Opened 11 years ago
Closed 11 years ago
UITour: Highlight effects don't occur if a highlight is moved to a different target without calling hideHighlight
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 31
People
(Reporter: MattN, Assigned: MattN)
References
Details
(Whiteboard: [Australis:P5])
Attachments
(1 file)
(deleted),
patch
|
Unfocused
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
There was nothing to trigger the effect again if the specified effect was the same as the current highlight. This is for the case where you simply want to move a highlight without calling hideHighlight in between. This was brought to my attention by :agibson.
The workaround is to always call hideHighlight before a showHighlight so this is P5.
Attachment #8396926 -
Flags: review?(bmcbride)
Comment 1•11 years ago
|
||
Comment on attachment 8396926 [details] [diff] [review]
v.1 Set the effect to "none" and flush before setting an effect
Review of attachment 8396926 [details] [diff] [review]:
-----------------------------------------------------------------
Holy gaping hole in the web api, batman.
Attachment #8396926 -
Flags: review?(bmcbride) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Agreed, having to think about layout flushes as a web developer feels dirty to me.
Assignee | ||
Comment 3•11 years ago
|
||
status-firefox29:
--- → affected
status-firefox30:
--- → affected
status-firefox31:
--- → affected
Flags: in-testsuite+
Whiteboard: [Australis:P5] → [Australis:P5][fixed-in-fx-team]
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 8396926 [details] [diff] [review]
v.1 Set the effect to "none" and flush before setting an effect
[Approval Request Comment]
Bug caused by (feature/regressing bug #): UITour initial effect implementation
User impact if declined: a highlight animation may not occur following another highlight
Testing completed (on m-c, etc.): Locally, m-c soon
Risk to taking this patch (and alternatives if risky): Low risk 2 line fix to trigger the animation with a test
String or IDL/UUID changes made by this patch: None
Attachment #8396926 -
Flags: approval-mozilla-beta?
Attachment #8396926 -
Flags: approval-mozilla-aurora?
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P5][fixed-in-fx-team] → [Australis:P5]
Target Milestone: --- → Firefox 31
Assignee | ||
Updated•11 years ago
|
Updated•11 years ago
|
Attachment #8396926 -
Flags: approval-mozilla-beta?
Attachment #8396926 -
Flags: approval-mozilla-beta+
Attachment #8396926 -
Flags: approval-mozilla-aurora?
Attachment #8396926 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 6•11 years ago
|
||
Assignee | ||
Comment 7•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•