Closed
Bug 989530
Opened 11 years ago
Closed 11 years ago
Quickshare should use text/plain type for links
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 31
People
(Reporter: wesj, Assigned: wesj)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
We currently use text/html as our default, which leads to a whole slew of sharing apps not appearing. We should use text/plain.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8398816 -
Flags: review?(mark.finkle)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8398816 [details] [diff] [review]
Patch
>diff --git a/mobile/android/base/prompts/PromptListItem.java b/mobile/android/base/prompts/PromptListItem.java
>+ public final static String DEFAULT_MIME_TYPE = "text/plain";
Not needed. You are pulling it from GeckoActionProvider.
r+, but remove the unneeded addition
Attachment #8398816 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
I fixed this in bug 990364.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
|
||
Comment 4•11 years ago
|
||
Based on comment 6 from Bug 989532
->Context menu links and the main menu now use text/plain for their mimetype, and all use the default history file.
Verified on 32 Nightly 05/26, 31 Aurora 05/26 and 30 Beta 6.
I will mark this bug as verified fixed
Status: RESOLVED → VERIFIED
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•