Closed Bug 995872 Opened 11 years ago Closed 6 years ago

Accept both variants when searching quoted strings in the debugger

Categories

(DevTools :: Debugger, enhancement, P3)

Product:
DevTools
Component:
Debugger
Platform:
Other
All
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: karlcow, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [polish-backlog])

When searching through Javascript code in the debugger section. These two strings should trigger the same results: !addeventlistener('click' !addeventlistener("click" It might be tricky in some cases but it could be useful to have the possibility to explore without having to type twice for finding the right quote ' or " which has been used.
Severity: normal → enhancement
Summary: Search and quote strings → quote strings in search area of the debugger
Is this only for the debugger, or for the script editor and inspector as well? IMO we can have a more comprehensive "smart search" option (make it an inspector pref) that also handles spaces and the like. Maybe even function definitions (`function abc` vs `abc=function`). I would love to work on this (especially the smart search, if we're having it), though I'm a bit busy these days so I won't assign this to myself until I get time.
What might be even more useful, and would cover this use case as well, is to have some form of fuzzy search for the debugger. What do people think of that idea?
Summary: quote strings in search area of the debugger → Accept both variants when searching quoted strings in the debugger
Whiteboard: [polish-backlog]
Priority: -- → P2
Product: Firefox → DevTools

I would prefer passing on this request for a couple of reasons

  1. updating our text search functionality across all tools is a significant feature
  2. it is good for search to be consistent with what editors do. i.e. it could be confusing to users to show matches that they would not expect
  3. the debugger supports regex searches, so it is possible to search addEventListener\(("|'|)click("|'|)\)
Flags: needinfo?(kdubost)
Flags: needinfo?(hkirschner)
Priority: P2 → P3

As regexp seems to solve this problem.

Maybe this is something to keep in mind for future editor-migration/Monaco work?

Flags: needinfo?(hkirschner)

Glad to discover that regex is available in the debugger. <3

Flags: needinfo?(kdubost)

wontfix for now, until we have a use case that isn't covered already.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Blocks: 1565711
Blocks: 1565713
No longer blocks: 1565711
No longer blocks: 1565713
You need to log in before you can comment on or make changes to this bug.