Closed Bug 1000660 Opened 11 years ago Closed 10 years ago

Fix PTexture protocal usage problem

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla32

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(3 files, 1 obsolete file)

temporary patch - Enable IPC message log
(deleted), patch
Details | Diff | Splinter Review
temporary patch - Do not call PTextureChild::SendRemoveTextureSync()
(deleted), patch
Details | Diff | Splinter Review
patch v2 - Remove TextureParent::RecvRemoveTextureSync()
(deleted), patch
sotaro
: review+
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #1000525 +++ By enabling IPC message log, I faced the b2g process crash withing PTextureParent class function.
Summary: "pipe error: Bad file number" happens during running WindowTest app → Fix PTexture protocal usage problem
The patch is used to enable IPC message log.
This is a temporary path just to confirm to prevent the b2g process crash. By applying the patch, b2g start up normally when IPC message log is enabled. Without the patch, b2g process crash when IPC message log is enabled.
gecko IPC seem not permit to call PTextureParent::Send__delete__(this) during receiving sync IPC. It actually happens in TextureParent::RecvRemoveTextureSync(). within Send__delete__(), PTextureParent is removed from Manager.
attachment 8411526 [details] [diff] [review] actually seem not make a problem. Before TextureClient::ForceRemove() is called, TextureClient is already removed from related CompositableHost if TEXTURE_DEALLOCATE_CLIENT is set. TEXTURE_DEALLOCATE_CLIENT flag seems to be used only on ImageClient.
Assignee: nobody → sotaro.ikeda.g
No longer blocks: 1000525
Attachment #8416901 - Flags: feedback?(nical.bugzilla)
Status: NEW → ASSIGNED
Status: ASSIGNED → NEW
Attachment #8416901 - Flags: feedback?(nical.bugzilla) → feedback+
Attachment #8416901 - Flags: review?(nical.bugzilla)
Blocks: 971946
Attachment #8416901 - Flags: review?(nical.bugzilla) → review+
Un-bitrot. Carry "r=nical".
Attachment #8416901 - Attachment is obsolete: true
Attachment #8421435 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/7c62af2b1ac9
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Depends on: 1014360
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: