Closed Bug 1000675 Opened 10 years ago Closed 10 years ago

Fix a few stylistic issues in example codegen

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla31

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

Don't always include nsContentUtils in example codegen, fix example header guards to not end with __, don't use fully-qualified names in argument types when those argument types are in the mozilla::dom namespace already, and include headers from mozilla/d
(deleted), patch
jst
: review+
Details | Diff | Splinter Review 
This came up in bug 995385.  Specifically:

* Addition of a trailing "__" to #ifndef guards on header files
* Use of "mozilla::dom::Key" instead of "Key" in argument types
* Inclusion of nsContentUtils.h in the generated .cpp

The second item on that list is due to us switching to nativeType in bug 804725 and not doing the prettification we do for return values.

Patch coming up.
Attachment #8411536 - Flags: review?(jst) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f394d14ac89
Flags: in-testsuite-
Whiteboard: [need review]
https://hg.mozilla.org/mozilla-central/rev/2f394d14ac89
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: