Closed
Bug 1000936
Opened 11 years ago
Closed 10 years ago
[e10s] Buttons on safe browsing warning page don't do anything
Categories
(Toolkit :: Safe Browsing, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla34
| Tracking | Status | |
|---|---|---|
| e10s | + | --- |
People
(Reporter: blassey, Assigned: evilpie)
References
()
Details
Attachments
(1 file)
|
(deleted),
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
1) go to https://www.itisatrap.org/firefox/its-a-trap.html
2) try to click on either button "Get me out of here" or "Why was this page blocked?"
nothing happens
|
Reporter | |
Comment 1•11 years ago
|
||
I should have noted that this is in a remote tab
Summary: Buttons on safe browsing warning page don't do anything → [e10s] Buttons on safe browsing warning page don't do anything
|
|
Reporter | |
Updated•11 years ago
|
tracking-e10s:
--- → ?
|
|
Reporter | |
Updated•11 years ago
|
Blocks: old-e10s-m2
|
||
Updated•11 years ago
|
Assignee: nobody → ally
|
|
Reporter | |
Updated•10 years ago
|
Priority: -- → P1
|
Assignee | |
Comment 2•10 years ago
|
||
Seems to me that this already mostly worked. Just the "Get me out of here" button was using content.location = url, which crashed the child. I took that chance and replaced all uses of content.location on that page.
Assignee: ally → evilpies
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8463880 -
Flags: review?(mconley)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8463880 [details] [diff] [review]
about-blocked
Review of attachment 8463880 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/base/content/browser.js
@@ +2677,5 @@
> url = url.split("|")[0];
> } catch(e) {
> Components.utils.reportError("Couldn't get homepage pref: " + e);
> }
> + gBrowser.loadURI(url);
There's a content.location = reportURL; in onAboutBlocked that we should replace as well.
Attachment #8463880 -
Flags: review?(mconley) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify+
|
||
Comment 6•10 years ago
|
||
Reproduced the initial issue using an old Nightly (2014-04-24), verified that using a Nightly build (34.0a1 and 35.0a1) after 2014-07-30 the issues does not reproduce anymore. Verified on Windows 7 64bit, Ubuntu 14.04 64bit and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•