Krzysztof Mioduszewski[:tauzen] Assignee
	Description • 11 years ago

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.116 Safari/537.36

Steps to reproduce:

NfcManager.handleNdefMessage processes NDEF message and returns an object which is used to create MozActivity later on. handleNdefMessage uses several helper methods (formatXXX) which basing on TNF (and record type in case of well known record). Test suit for all these methods should be implemented, as a result it may later on lead to some refactoring of these methods.

	Krzysztof Mioduszewski[:tauzen] Assignee
	Comment 1 • 11 years ago

I would like to work on that.

	Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]
	Comment 2 • 11 years ago

You could also check Bug 1000830 I filed yesterday for the refactoring in handleNDEFMessage.

	Krzysztof Mioduszewski[:tauzen] Assignee
	Comment 3 • 11 years ago

List of changes:
1. moved NfcUtils and NfcUtilsManager tests to separate file in apps/system/test/unit/nfc_utils_test.js
2. Added 'handleNdefMessage' test suit with following test cases: tnf empty, tnf well known rtd text utf-8, tnf well known rtd uri, tnf well known rtd smart poster, tnf mime text/plain
3. Added 'handleNdefMessage not supported records' test suit. This test suit is skipped and contains 4 tests, each for bugs which I found working on this patch. Bug numbers are available in comments.

Once this lands and bugs from point 3. would be cleared I propose to move formatXXX methods to NfcManagerUtils with suitable test cases moved to separate file (nfc_manager_utils_test.js)

	Ken Chang[:kenkai]
	Comment 4 • 11 years ago

This bug blocks NFC 2.0 release.

	Krzysztof Mioduszewski[:tauzen] Assignee
	Comment 5 • 11 years ago

This patch has added new test file nfc_utils_test.js. Will it be automatically picked up by test runner and TravisCI? Or do we need to configure it somewhere? Locally I had to add it to gaia/dev_apps/test-agent/config.json to run the tests. But this file is no tracked by git.

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 11 years ago

The PR needs to be rebased.

	Krzysztof Mioduszewski[:tauzen] Assignee
	Comment 7 • 11 years ago

rebased

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 11 years ago

Master: https://github.com/mozilla-b2g/gaia/commit/1cf9ee86885dc6f7a18e8df0a70d57dc5c722c40