Comment on attachment 8412125 [details] [diff] [review] Patch Review of attachment 8412125 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for fixing this! ::: xpcom/base/nsCycleCollector.cpp @@ +220,3 @@ > // various cycle collector optimizations to give a fuller picture of > +// the heap. If set to "shutdown", only shutdown logging will be WantAllTraces. > +// default is none. nit: please turn this into a sentence, like "The default is none." or something. @@ +274,5 @@ > } > } > mLogThisThread = threadLogging && processLogging; > + > + const char * allTracesEnv = PR_GetEnv("MOZ_CC_ALL_TRACES"); nit: const char* allTracesEnv @@ +276,5 @@ > mLogThisThread = threadLogging && processLogging; > + > + const char * allTracesEnv = PR_GetEnv("MOZ_CC_ALL_TRACES"); > + if (allTracesEnv) { > + if (!strcmp(allTracesEnv, "all")) nit: please add braces around both branches of this if. You're in Gecko now. ;) @@ +3426,5 @@ > mListener = aManualListener; > aManualListener = nullptr; > if (!mListener && mParams.LogThisCC(isShutdown)) { > nsRefPtr<nsCycleCollectorLogger> logger = new nsCycleCollectorLogger(); > + if (isShutdown && mParams.AllTracesThisCC(isShutdown)) { Remove the "isShutdown &&" here.

Can you update the documentation at https://developer.mozilla.org/en-US/docs/Mozilla/Performance/GC_and_CC_logs#Generating_GC_and_CC_logs for this change? In particular with what version this changed in.

I can do that.

Updated. Thanks for pointing out this problem, Kyle.