Closed
Bug 1001272
Opened 11 years ago
Closed 11 years ago
AEC distorted (especially on Mac) due to 10ms rechunking
Categories
(Core :: WebRTC: Audio/Video, defect, P1)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla31
Tracking | Status | |
---|---|---|
firefox30 | --- | unaffected |
firefox31 | --- | affected |
backlog | Fx32+ |
People
(Reporter: jesup, Assigned: jesup)
References
Details
(Whiteboard: [p=1, 1.5:p1, ft:webrtc][s=fx32])
Attachments
(1 file)
(deleted),
patch
|
padenot
:
review+
|
Details | Diff | Splinter Review |
A last-second change to patch 3 of bug 694814 (Move AEC to GUM), adding far-end observers, introduced a bug missed in review.
When rechunking to 10ms (due to webrtc.org restrictions) the far-end observer code was converted from a hand-coded loop to do sample conversion, to a call to ConvertAudioSamples(). It was reviewed, but missed in the conversion (or accidentally deleted) was the need to now separately bump the input pointer so it would be correct for the next iteration of the for() loop.
This led to snippets of repeated audio replacing correct audio, depending on the chunk sizes processed by MSG and passed over. These could be far worse on some hardware/driver setups (such as certain macs). The distorted far-end audio was used only for AEC, so the AEC was only partially functional (again, very system-dependent).
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #8412365 -
Flags: review?(paul)
Assignee | ||
Updated•11 years ago
|
status-firefox30:
--- → unaffected
status-firefox31:
--- → affected
Updated•11 years ago
|
Attachment #8412365 -
Flags: review?(paul) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Target Milestone: --- → mozilla31
Updated•11 years ago
|
backlog: --- → Fx32+
Whiteboard: [priority, p=1, ft:webrtc]
Updated•11 years ago
|
Priority: -- → P1
Whiteboard: [priority, p=1, ft:webrtc] → [p=1, 1.5:p1, ft:webrtc]
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Whiteboard: [p=1, 1.5:p1, ft:webrtc] → [p=1, 1.5:p1, ft:webrtc][s=fx32]
You need to log in
before you can comment on or make changes to this bug.
Description
•