Closed
Bug 1001363
Opened 11 years ago
Closed 11 years ago
Add Fulah / Pulaar-Fulfulde (ff) input method for Gaia
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S1 (9may)
| Tracking | Status | |
|---|---|---|
| b2g-v2.0 | --- | fixed |
People
(Reporter: arky, Assigned: arky)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
rudyl
:
review+
|
Details | Diff | Splinter Review |
Please add Fulah input method for Gaia. The patch for this keyboard is attached for review.
Attachment #8412505 -
Flags: review?(rlu)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8412505 [details] [diff] [review]
Fulah-FxOS-Keyboard.patch
Review of attachment 8412505 [details] [diff] [review]:
-----------------------------------------------------------------
Looks pretty good to me, r+.
BTW, please add this new layout as additional new layout for FF language in:
build/config/keyboard-layouts.json
if English layout is also required for FF, or just replace English with this new one.
--
Could you please supply a pr so that I could merge, or you could merge this yourself?
::: apps/keyboard/js/layouts/ff.js
@@ +2,5 @@
> + label: 'Fulah',
> + menuLabel: 'Pulaar-Fulfulde',
> + imEngine: 'latin',
> + types: ['text', 'url', 'email'],
> + autoCorrectLanguage: '',
We don't need to specify this if there is no dictionary available.
Attachment #8412505 -
Flags: review?(rlu) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
Thank you for the review. I have file a PR for this
https://github.com/mozilla-b2g/gaia/pull/18804
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
Assignee: nobody → hitmanarky
Status: NEW → RESOLVED
Closed: 11 years ago
status-b2g-v2.0:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)
|
||
Updated•10 years ago
|
Blocks: Keyboards-FxOS
You need to log in
before you can comment on or make changes to this bug.
Description
•