Kevin Grandon :kgrandon Assignee
	Description • 10 years ago

Proposal: Remove the ROCKETBAR build flag in favor of a unified build flag to enable all haida features and preferences. The flag would enable the following features:

Rocketbar
Settings Drawer
Notifications Tray
Task Manager
Edge Gestures
System Browser
Opt into vertical homescreen

	Kevin Grandon :kgrandon Assignee
	Comment 2 • 10 years ago

Comment on attachment 8413073 [details]
Github pull request

Hi Yuren - please review this whenever you have time. Thanks!

	Ben Francis [:benfrancis]
	Comment 3 • 10 years ago

Huh? If homescreen and edge gestures ship in 2.0 and everything else doesn't ship until 2.1 but work has already started, don't we need a way to toggle them independently?

	Kevin Grandon :kgrandon Assignee
	Comment 4 • 10 years ago

In that case HAIDA=1 can just enable the remaining features. (Rocketbar, Settings Drawer, Notifications Tray).

It doesn't seem necessary to have multiple levels for the rocketbar flag now that we've made progress on the UI and it isn't enabled by default.

	Ben Francis [:benfrancis]
	Comment 5 • 10 years ago

OK, makes sense.

	Kevin Grandon :kgrandon Assignee
	Comment 6 • 10 years ago

Comment on attachment 8413073 [details]
Github pull request

Adding some more reviewers in case Yuren is busy. Anyone have time? Thanks!

	Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)
	Comment 7 • 10 years ago

Comment on attachment 8413073 [details]
Github pull request

r=yurenju if nits are addressed.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 8 • 10 years ago

Glad that Yuren has been faster :)

	Kevin Grandon :kgrandon Assignee
	Comment 9 • 10 years ago

Thanks for taking a look guys!

Landed: https://github.com/mozilla-b2g/gaia/commit/94ffc335253ad226106b0e601af49f3eea22dfed