Open Bug 1001635 Opened 11 years ago Updated 3 years ago

Add relations for MathMLAccessibles

Categories

(Core :: Disability Access APIs, enhancement)

enhancement

Tracking

()

People

(Reporter: jwei, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 4 obsolete files)

Set up relations described on https://wiki.mozilla.org/Accessibility/MathML.
Blocks: 1001641
Attached patch MathML relations WIP (obsolete) (deleted) — Splinter Review
Added all relations listed on the wiki page. The necessity of these relations is still in discussion (forward direction, e.g. fraction -> numerator, due to the rigidity of the MathML spec, and the backwards direction, e.g. numerator -> fraction, due to various other factors).
Attached patch MathML relations (deleted) — Splinter Review
Switched to utils class for common MathML implementations.
Attachment #8412912 - Attachment is obsolete: true
Attachment #8434644 - Flags: review?(surkov.alexander)
Comment on attachment 8434644 [details] [diff] [review] MathML relations Review of attachment 8434644 [details] [diff] [review]: ----------------------------------------------------------------- rs=me ::: accessible/src/generic/MathMLUtils.cpp @@ +534,5 @@ > + case RelationType::MATHML_ROW_FOR: { > + if (accRole != roles::MATHML_ROW) > + break; > + > + aRelation->AppendIter(new ChildIterator(aAccessible)); this is rather crazy since its full analogue of GetChildren() but that may be ok for now. We'd need to run all of these through some implementation to see what makes sense and what should go away
Attachment #8434644 - Flags: review?(surkov.alexander) → review+
Attached patch MathML relations (obsolete) (deleted) — Splinter Review
Unbitrotting...
Attached patch MathML relations (obsolete) (deleted) — Splinter Review
Unbitrot
Attachment #8532937 - Attachment is obsolete: true
Attachment #8557466 - Attachment is patch: true
Blocks: 1001637
No longer blocks: 1001641
Attached patch MathML relations (obsolete) (deleted) — Splinter Review
Unbitrotting the patch again. However, the way we map MathML elements to roles has changed in Alexander's patch for bug 1001635, so this might need some refactoring...
Attachment #8557466 - Attachment is obsolete: true
yes, I'll handle it
Blocks: 1001641
No longer blocks: 1001637
Depends on: 1001637
No longer depends on: 1001634
Attachment #8574886 - Attachment is obsolete: true
Attached patch Put relations into MarkupMap (deleted) — Splinter Review
This is the continuation of attachment 8623966 [details] [diff] [review] to move relations into MarkupMap. IIUC, if we have <mfrac> [NUMERATOR] [DENOMINATOR] </mfrac> then we can implement the relation RELATION_MATHML_NUMERATOR by associating the relation to the nsGkAtoms::mfrac_ element. However, to implement the converse relation RELATION_MATHML_DENOMINATOR_OF, we would need to associate it to *any* MathML elements that can potentially be a numerator. So I don't think this map stuff is really a good idea to implement Jonathan's relations.

The bug assignee didn't login in Bugzilla in the last 7 months.
:Jamie, could you have a look please?
For more information, please visit auto_nag documentation.

Assignee: jwei → nobody
Flags: needinfo?(jteh)
Severity: normal → --
Type: defect → enhancement
Flags: needinfo?(jteh)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: