Closed
Bug 1001757
Opened 11 years ago
Closed 10 years ago
Add ability to store core apps outside of profile on B2G Desktop
Categories
(Core Graveyard :: DOM: Apps, defect)
Tracking
(firefox39 fixed)
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: qdot, Assigned: qdot)
References
Details
(Whiteboard: [systemsfe] [p=5])
Attachments
(2 files)
On desktop, we need a way to set a pref that will allow us to store certified apps in a different place than the profile, so that we can simulate profile updates in integration tests.
See Bug 1001680 Comment #2 for more info.
Assignee | ||
Comment 1•11 years ago
|
||
This will most likely be by setting a debug pref to let the system know that we are trying to run upgrade tests.
Whiteboard: [systemsfe] [p=5]
Updated•11 years ago
|
Component: GonkIntegration → DOM: Apps
Product: Firefox OS → Core
Updated•11 years ago
|
Target Milestone: 2.0 S1 (9may) → 2.0 S2 (23may)
Updated•10 years ago
|
Target Milestone: 2.0 S2 (23may) → ---
Assignee | ||
Comment 2•10 years ago
|
||
Talked to fabrice about this on IRC. Going to set up a pref (b2g.apps.desktop_coreappsdir) to point to where core apps are built. Will need to change this in the B2G directory provider, as well as the gaia build system, and make sure they sync up. After this, we should be able to provide a location to build the apps into, then redistribute profiles as necessary for testing.
Also talked about having a command line argument for core app location, which the more I think about it, could be useful as an override for this without having to go in and edit prefs. Worth doing both maybe?
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8576307 -
Flags: review?(fabrice)
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8576329 [details]
[gaia] qdot:1001757-move-core-apps > mozilla-b2g:master
Gaia build system changes for building core apps outside of the profile on b2g desktop. Contains integration tests for making sure external app directory building works.
Attachment #8576329 -
Flags: review?(ricky060709)
Comment 6•10 years ago
|
||
Comment on attachment 8576329 [details]
[gaia] qdot:1001757-move-core-apps > mozilla-b2g:master
Sorry I don't totally understand here =(
If you want to modify PROFILE_DIR, you could do
PROFILE_DIR?=$(GAIA_DIR)$(SEP)$(PROFILE_FOLDER)
Attachment #8576329 -
Flags: review?(ricky060709) → review-
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8576329 [details]
[gaia] qdot:1001757-move-core-apps > mozilla-b2g:master
Ok. I fixed the ?= and the github comment.
The reason I needed to move PROFILE_DIR up to its own variable instead of just having it in config is because before this patch, we assumed that the webapps dir that gaia builds would be in PROFILE_DIR. After this patch, we can now relocate the webapps dir wherever we want, mostly for upgrade testing purposes. We'll need to keep PROFILE_DIR the same (because we still want the profile in $GAIA_DIR/profile), and for most cases, we'll want to keep webapps in PROFILE_DIR too.
Attachment #8576329 -
Flags: review- → review?(ricky060709)
Comment 8•10 years ago
|
||
Comment on attachment 8576329 [details]
[gaia] qdot:1001757-move-core-apps > mozilla-b2g:master
OK, it seems fine to me.
Could you tell me more detail steps of how do you simulate profile updates in integration tests? Thanks
Attachment #8576329 -
Flags: review?(ricky060709) → review+
Comment 9•10 years ago
|
||
Comment on attachment 8576307 [details] [diff] [review]
Patch 1 (v1) - Add ability to store core apps outside of profile on desktop B2G
Review of attachment 8576307 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with nits fixed
::: b2g/components/DirectoryProvider.js
@@ +15,4 @@
> const LOCAL_DIR = "/data/local";
> const UPDATES_DIR = "updates/0";
> const FOTA_DIR = "updates/fota";
> +const DESKTOP_COREAPPSDIR_PREF = "b2g.apps.desktop_coreappsdir"
nit: I would just call it b2g.coreappsdir
::: modules/libpref/init/all.js
@@ +4631,5 @@
> pref("dom.secureelement.enabled", false);
> #endif
> +
> +// Preference for moving where desktop b2g apps are stored.
> +pref("b2g.apps.desktop_coreappsdir", "")
\ No newline at end of file
I don't think you need that since DirectoryProvider.js can deal with the pref being not set at all.
Attachment #8576307 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 10•10 years ago
|
||
Assignee | ||
Comment 11•10 years ago
|
||
Gaia merge: https://github.com/mozilla-b2g/gaia/pull/28818
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•