Closed Bug 1002385 Opened 11 years ago Closed 11 years ago

[10n] [Marketplace] text not localized when a proxy error happens

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 912445

People

(Reporter: juanpbf, Unassigned)

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Attached image Screenshot of the message (deleted) —
This bug has been reproduced only once on a FxOS 1.3 build for ZTE Open II. When opening the Marketplace app, an error happen, and the following text was shown, but it was not localized: "Firefox is configured to use a proxy server that is refusing connections" The general language was set to Spanish, so this text should localized accordingly
Mike - Can you find out if this a untranslated string in general or is this just a problem where we don't have a Spanish translation for this app error page?
Component: Gaia::System → Gaia::System::Window Mgmt
Flags: needinfo?(mhenretty)
The message is coming from gecko here [1] and being redisplayed in gaia here [2]. It was my understanding that gecko messages were localized according to device settings. Is this not the case? Or perhaps could the `appstring.properties` file not have Spanish translations? I'm afraid I don't know much about how localization works in Gecko. 1.) http://hg.mozilla.org/mozilla-central/file/e350a1923f0e/b2g/locales/en-US/chrome/overrides/appstrings.properties#l23 2.) https://github.com/mozilla-b2g/gaia/blob/fa958a581df215559439152e50bb99532493e204/apps/system/js/net_error.js#L135
Flags: needinfo?(mhenretty)
Fabrice - Do you have any ideas in regards to what's stated in comment 2?
Flags: needinfo?(fabrice)
The title is correctly translated but not the message body. That looks like an incomplete translation to me, but I don't know where the spanish translation is stored to verify. Delphine, help!
Flags: needinfo?(fabrice) → needinfo?(lebedel.delphine)
If this appears when lauching Marketplace, I believe that the translation should be in one of the Marketplace localization tools. Peiying, any idea about this please? thanks!
Flags: needinfo?(lebedel.delphine) → needinfo?(pmo)
(In reply to Delphine Lebédel [:delphine - use needinfo] from comment #5) > If this appears when lauching Marketplace, I believe that the translation > should be in one of the Marketplace localization tools. > Peiying, any idea about this please? > thanks! This isn't related to marketplace. The app error page is part of Gaia, but the string comes from gecko.
No, this is not from Marketplace.
Delphine, do you know if/where we would have the Spanish translation for this string in gecko? http://hg.mozilla.org/mozilla-central/file/e350a1923f0e/b2g/locales/en-US/chrome/overrides/appstrings.properties#l23
Flags: needinfo?(pmo) → needinfo?(lebedel.delphine)
I've been trying to find out but I have no idea. Asking Pike if he can help out with this
Flags: needinfo?(lebedel.delphine) → needinfo?(l10n)
The string is here, but Pike is definitely the right person to ask (I have no idea whether or not we still use those /b2g repositories) http://hg.mozilla.org/l10n-central/es-ES/file/3e71d29eacde/b2g/chrome/overrides/appstrings.properties#l18 Also, maybe bug 893802 will help
Vivien, this seems to be one of the gecko strings we show in fx os. I don't have a plan on how to deal with those. What's your take?
Flags: needinfo?(l10n) → needinfo?(21)
(In reply to Axel Hecht [:Pike] from comment #11) > Vivien, this seems to be one of the gecko strings we show in fx os. > > I don't have a plan on how to deal with those. What's your take? My understanding is that this message comes from Gecko (mxr.mozilla.org/mozilla-central/source/b2g/locales/en-US/chrome/overrides/appstrings.properties) has noticed into some comments. There is more specifics informations about the error as a list of parameters at https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/net_error.js#L108 It's not clear to me what those parameters are, but if one of them is the equivalent of the key that is used for localizations then we can move back the localization into Gaia, with a net_error.properties file. Pike what do you think ?
Flags: needinfo?(21)
Oh, looking at this more closely now, this is actually a dupe of bug 912445, and already fixed on master. That missed 1.4, though.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
This is not a dupe. We had a different implementation used in 1.3 for handling of the strings & that other bug uses a different UX. Re-adding needinfo for comment 12.
Status: RESOLVED → REOPENED
Flags: needinfo?(l10n)
Resolution: DUPLICATE → ---
Vance - Can you find out if this is a cert blocker?
Flags: needinfo?(vchen)
The bug that I pointed to does exactly what Vivien suggested by adding more error cases to our overwrites of the neterror page.
Flags: needinfo?(l10n)
Whiteboard: [systemsfe]
There are two parts to this bug: 1.) Improper message translation for the proxy error. As :Pike pointed out, this is fixed in bug 912445 but was never uplifted. If we are worried about this specific error happening on 1.3/1.4, we should nom it and and triage for uplift. 2.) The more general problem we have is the fallback case where we get an unrecognized error from gecko, and we simply append error the description handed to us by gecko (https://github.com/mozilla-b2g/gaia/blob/e0ce0381c573374a20027160de2916af43f55762/apps/system/js/net_error.js#L188). As Vivien alluded to in comment 12, we can use the `error.e` property as the localization key for the gecko string. The only question left is, what all message can possibly come from gecko? Is it limited to just these https://mxr.mozilla.org/mozilla-central/source/dom/locales/en-US/chrome/appstrings.properties?
Per discussion with TEF, this is not a cert blocker.
Flags: needinfo?(vchen)
Guess that means we're going to have to wait for bug 912445 then.
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: