Closed
Bug 1002415
Opened 11 years ago
Closed 11 years ago
Imip bar button type is not adjusted automatically
Categories
(Calendar :: Lightning Only, defect, P1)
Calendar
Lightning Only
Tracking
(Not tracked)
RESOLVED
FIXED
3.3
People
(Reporter: MakeMyDay, Assigned: MakeMyDay)
Details
Attachments
(1 file)
(deleted),
patch
|
Fallen
:
review+
Fallen
:
approval-calendar-aurora+
|
Details | Diff | Splinter Review |
The automated type adjusting of new imipbar buttons is currently broken. There is a related error log message and I already have a fix for this. Due to a system crash it may take some days to provide it.
Comment 1•11 years ago
|
||
Could you please provide the related error message here or add it to the summary to ensure this bug shows up when searching using the error message as input.
Updated•11 years ago
|
Priority: -- → P1
Comment 2•11 years ago
|
||
When your systems are up again, maybe it would make sense to write a mozmill test for this too.
Flags: in-testsuite?
Assignee | ||
Comment 3•11 years ago
|
||
If the merge alreday was done, requesting approval for aurora as well.
Attachment #8414452 -
Flags: review?(philipp)
Assignee | ||
Comment 4•11 years ago
|
||
Forgot to post the error message:
[JavaScript Error: "[Exception... "[JavaScript Error: "document.getElementById(...) is null" {file: "chrome://lightning/content/imip-bar.js" line: 138}]'[JavaScript Error: "document.getElementById(...) is null" {file: "chrome://lightning/content/imip-bar.js" line: 138}]' when calling method: [calIOperationListener::onOperationComplete]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: file:///C:/Mozilla/Debugging/Thunderbird/Profiles/unstable/central/Test-central-en/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calCompositeCalendar.js :: calCompositeGetListenerHelper.prototype.onOperationComplete :: line 520" data: yes]"]
Comment 5•11 years ago
|
||
Comment on attachment 8414452 [details] [diff] [review]
FixBrokenAutomatedImipBarButtonAdjusting-V1.diff
Review of attachment 8414452 [details] [diff] [review]:
-----------------------------------------------------------------
r/a=philipp
Attachment #8414452 -
Flags: review?(philipp)
Attachment #8414452 -
Flags: review+
Attachment #8414452 -
Flags: approval-calendar-aurora+
Comment 6•11 years ago
|
||
Could you file a new bug to write a mozmill test for this?
Flags: in-testsuite?
Keywords: checkin-needed
Assignee | ||
Comment 7•11 years ago
|
||
Done, see bug 1003207. And sorry for the typo ;-)
Comment 8•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•