Closed Bug 1002514 Opened 11 years ago Closed 9 years ago

Highlight ghost window entry in red if it is non-zero

Categories

(Toolkit :: about:memory, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: mccr8, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [MemShrink:P3])

It would be nice if the "ghost-windows" number at the bottom gets highlighted in red if it is non-zero, as this is usually a sign of badness.  It is fine if you think we should just leave red as a sign of internal inconsistency, like negative values.
Also we could highlight the entire about:memory page in red. ;)
It's an interesting idea but I'm not sure how to implement it. I absolutely don't want to hardwire special treatment of "ghost-windows" in aboutMemory.js -- I've been removing hardwiring of that sort over time and am very happy about it.

So there would have to be a way, when making a report, to flag that a particular measurement should be highlighted if it has a certain value... which isn't easy, because there are so many places making reports.
Whiteboard: [MemShrink] → [MemShrink:P3]
We have this closure object being passed around to CollectReports, could we ask it whether it supports nsIImportantMeasurementFlagger, and then call some method on it when we have an "unusual" measurement?
I don't think anybody cares enough to fix this.
Blocks: GhostWindows
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.