Lightning 3.3a1 on Windows 8.1 Last good: 20140427 https://tbpl.mozilla.org/?tree=Thunderbird-Trunk&showall=1&rev=109486fb2b22 First bad: 20140428 https://tbpl.mozilla.org/?tree=Thunderbird-Trunk&showall=1&rev=c8a51e3fbe7e When creating an event and opening the dialog for adding attendees, the autocomplete widget for entering a contact reads 'null', values entered in that field will be ignored in the New Event dialog which opened it. Seems to be a regression from bug 959209.

Quite simple fix. If inputValue is null, which is obviously the case for the first row without an attendee, setting input.value = inputValue breaks autocomplete, while input.setAttribute("value", inputValue) is responsible to display "null" in the textbox. Beside that, attendee autocomplete is here also affected by bug 1003856, which becomes obvious with this one fixed. Do we need to push this to aurora, too? If so, I'm requesting approval.

Comment on attachment 8416517 [details] [diff] [review] FixBrokenAutocompleteInAttendeeDialog-V1.diff Review of attachment 8416517 [details] [diff] [review]: ----------------------------------------------------------------- ::: calendar/base/content/dialogs/calendar-event-dialog-attendees.xml @@ +273,5 @@ > } > > + // don't set value with null, otherwise autocomplete stops working, > + // but make sure attendee and dirty are set > + if (inputvalue) { "inputvalue" should be "inputValue". Furthermore, inputValue could also be set to "" if it fails the |if (email && email.length)| check a few lines before.

Updated patch, considering Archaeopteryx's comments.

Comment on attachment 8416556 [details] [diff] [review] FixBrokenAutocompleteInAttendeeDialog-V2.diff Code looks good and patch works, aside from the TB bug you pointed out. r=philipp

What about aurora? I guess bug 959209 landed before the merge, but I'm not sure.

Yes it landed before the merge.

https://hg.mozilla.org/comm-central/rev/6717ec2e2e11 https://hg.mozilla.org/releases/comm-aurora/rev/14e652347dee