Closed
Bug 1002857
Opened 11 years ago
Closed 8 years ago
stop disabling GL layers for 10.6.2 and below
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: gal, Assigned: BenWa)
References
Details
Attachments
(1 file, 2 obsolete files)
This might break on some very old macs that didn't update to 10.6.3, but in that case you have much bigger problems anyway (security) plus its 3 versions behind current macosx. 10.6.3 is a free update. We should relnote this.
Reporter | ||
Comment 1•11 years ago
|
||
Assignee: nobody → gal
Reporter | ||
Comment 2•11 years ago
|
||
Attachment #8414142 -
Attachment is obsolete: true
Reporter | ||
Updated•11 years ago
|
Attachment #8414143 -
Flags: review?(bgirard)
Assignee | ||
Comment 3•11 years ago
|
||
We've supported 10.6.0 - 10.6.2 long enough. I think moving our official min requirement to 10.6.2 is a good move to focus resources on recent OSX.
But I feel like this needs broad approval so I'm going to bring this up in the next graphics meeting.
Assignee | ||
Comment 4•11 years ago
|
||
Note that we uplifted a patch to beta in FF18 (start of 2013) to restore this blacklist because of user report so the impact is likely to be non zero. I still think we should consider doing this however.
See bug 829710.
Comment 5•11 years ago
|
||
(In reply to Benoit Girard (:BenWa) from comment #3)
> We've supported 10.6.0 - 10.6.2 long enough. I think moving our official min
> requirement to 10.6.2 is a good move to focus resources on recent OSX.
>
> But I feel like this needs broad approval so I'm going to bring this up in
> the next graphics meeting.
For clarity, did you mean moving to 10.6.3 as minimum?
Assignee | ||
Comment 6•11 years ago
|
||
Yes I did.
We discussed this on the graphics meeting. Here's the summary:
- According to our crash data stats 10.6.0 - 10.6.2 has a trivial user base and consumes a small but disproportionate resources that would be better spent else where especially since 10.6.3 is a free patch.
We decided that we should instead take an independent decision to drop support for 10.6.2 and below which I will file as a dependent bug and we can discuss with the relevant parties. Once that bug is resolved this patch is a trivial r+ since it becomes dead code.
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 8414143 [details] [diff] [review]
patch
Let's wait on bug 1003270, once it's fixed this r+ is trivial.
Attachment #8414143 -
Flags: review?(bgirard)
Reporter | ||
Updated•11 years ago
|
Assignee: gal → bgirard
Updated•11 years ago
|
relnote-firefox:
--- → ?
Keywords: relnote
Comment 8•10 years ago
|
||
Like in bug 1003270, please resubmit to the release notes when it landed.
relnote-firefox:
? → ---
Assignee | ||
Comment 9•9 years ago
|
||
I'm not working on this. Given how much effort it is to blacklist a minor OS X version it will probably be easier to just wait until we drop 10.6 altogether.
Assignee | ||
Updated•9 years ago
|
Assignee: bgirard → nobody
Comment 10•8 years ago
|
||
We've now dropped support for < 10.9, see bug 1255589.
Assignee | ||
Comment 11•8 years ago
|
||
Alright now that we're not waiting on bug 1003270 we should get rid of this check.
Assignee: nobody → bgirard
Assignee | ||
Updated•8 years ago
|
Attachment #8414143 -
Attachment is obsolete: true
Assignee | ||
Comment 12•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/53720/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53720/
Attachment #8754092 -
Flags: review?(mstange)
Updated•8 years ago
|
Attachment #8754092 -
Flags: review?(mstange) → review+
Comment 13•8 years ago
|
||
Comment on attachment 8754092 [details]
MozReview Request: Bug 1002857 - stop disabling GL layers for 10.6.2 and below. r=mstange
https://reviewboard.mozilla.org/r/53720/#review50720
Might as well remove the gfxPlatformMac::AccelerateLayersByDefault() override completely.
Assignee | ||
Comment 14•8 years ago
|
||
I looked but it wasn't trivial. This does push it in the right direction however:
http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxPlatform.cpp#2166
Best to leave it as a follow-up.
Comment 15•8 years ago
|
||
Is MOZ_GL_PROVIDER not always defined for Mac? Mac uses GLContextProviderCGL, and I thought that define picked that.
Assignee | ||
Comment 16•8 years ago
|
||
Ohh you meant specifically the mac override. I assumed you meant everything because that's what I looked at doing.
Assignee | ||
Comment 17•8 years ago
|
||
Comment on attachment 8754092 [details]
MozReview Request: Bug 1002857 - stop disabling GL layers for 10.6.2 and below. r=mstange
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53720/diff/1-2/
Assignee | ||
Comment 18•8 years ago
|
||
Since my auto-land request didn't go through I amended the changes in Comment 15.
Comment 19•8 years ago
|
||
Comment 20•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•