Closed
Bug 1003041
Opened 11 years ago
Closed 11 years ago
Merge PRenderFrame() and InitRenderFrame() ?
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: smaug, Assigned: smaug)
References
Details
(Keywords: perf)
Attachments
(1 file)
(deleted),
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
Both PRenderFrame() and InitRenderFrame() are sync messages from child to parent
and based on profiles we end up waiting for the reply from the parent.
So,if we could do just one wait, not two.
It is hard to estimate how much that would help, but we end up waiting for
>10ms waiting for the replies.
I guess it would be fine to merge them as long as we keep the success parameter. I think I split them up because it seemed weird to have the constructor behave that way. But if it matters for performance, it seems fine.
Assignee | ||
Comment 3•11 years ago
|
||
It seems to be rather important from performance point of view.
Child process is just waiting for quite some time doing nothing.
(But need to think about initialization steps a bit more. I think we should aim
for no sync child-parent messages during normal <iframe mozbrowser> initialization.)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → bugs
Assignee | ||
Comment 4•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #8419775 -
Flags: review?(wmccloskey)
Attachment #8419775 -
Flags: review?(wmccloskey) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Commit message: "Bug 1003041 - Merge PRenderFrame() and InitRenderFrame() to avoid extra sync child->parent messaging, r=billm"
Keywords: checkin-needed
Comment 6•11 years ago
|
||
Keywords: checkin-needed
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•