Closed Bug 100319 Opened 23 years ago Closed 21 years ago

Turbo: Hangs or does not allow Windows 98 to shut down

Categories

(Core Graveyard :: QuickLaunch (AKA turbo mode), defect, P1)

x86
Windows 98
defect

Tracking

(Not tracked)

RESOLVED WORKSFORME
mozilla1.2alpha

People

(Reporter: jaimejr, Assigned: law)

References

Details

(Keywords: hang, qawanted, Whiteboard: [need info])

Build ID: 20010918003 Reproducible: Always Steps: 1. Install new build with Turbo ON. 2. Use the browser ... send some mail and stuff 3. Click on Windows Start button, and select Shut Down. 4. Click OK when presented witht the dialogue. Results: Frequently does not allow Win 98 to shut down, and always adds a few minutes to shut down process (if it works). Note: If I disable QuickLaunch, before shutting down, the system seems to shut-down as expected.
Blocks: 75599
Need to reproduce on other machines - Doron? Part of the shutdown time may be mail cleanup, and we may be responding to shutdown by only closing windows, when we really need to shutdown. ->law
Assignee: asa → law
Keywords: nsbranch
Target Milestone: --- → mozilla0.9.5
I installed the latest branch bits and cannot reproduce the problem. Jaime, do I need to do something specific to produce the error? I tried various combinations of leaving browser windows open, mail windows open, no windows open, etc. But maybe it's something specific like leaving a Mail compose window open or something that I didn't trigger. I will be looking at the code that handles shutdown to see if it looks like it does the right thing.
We have no code that handles WM_QUERYENDSESSION or WM_ENDSESSION (the messages Win32 sends at system shutdown). This means we do the default, which is nothing (so Windows ends up closing the open windows and terminates the process).
Could someone in QA please try to reproduce this? cc tpreston, gbush
Summary: Turbo: Hangs or does allow Windows 98 to shut down → Turbo: Hangs or does not allow Windows 98 to shut down
I do not believe this is a turbo problem specifically. My Win 98 Machine almost never shuts down (5% of the time it does) properly. This has been occuring since well before turbo, and I know it has on Jaime's machine as well. I have noticed no difference in the frequency of failing to shut down since running turbo. Win98 users are frankly use to this suckage and I don't see this as a stop ship, even if we do occasionally get in the way of shutdown - i.e. I don't think we're the only app that Win98 chokes on at shutdown (if we are one at all).
not able to reproduce on machine here in Install QA- Win98 shutdown faster than my other machines
Pls note, I see both a perf and shutdown completion imporvement when I exit QuickLaunch.
... before shutting down. This is my current workaround.
Placing "Turbo+" in Status Whiteboard, and marking nsbranch+ for Trudelle's short list query. Pls remove Turbo+ and nsbranch- if this is no longer on the short list.
Keywords: nsbranchnsbranch+
Whiteboard: Turbo+
nsbranch-, won't hold for what we can't readily reproduce.
Keywords: nsbranch+nsbranch-
Whiteboard: Turbo+
Target Milestone: mozilla0.9.5 → mozilla0.9.7
Blocks: 107067
Keywords: nsbranch-
*** Bug 101500 has been marked as a duplicate of this bug. ***
Blocks: 108795
Mass moving bugs that won't get fixed this milestone.
Target Milestone: mozilla0.9.7 → mozilla0.9.9
balancing move of Helper App Mgt feature work bugs to this milestone
Keywords: nsbeta1+
Target Milestone: mozilla0.9.9 → mozilla1.0
If the case still is that we can not successfully reproduce this, than maybe, we should push this one off after 1.0. That being said, I am still seeing this with Multiple Profilles, and it may cause some memory issues, too.
Depends on: 14807
I don't think we should ignore this bug. It is actually worse that the user can shutdown most of the time! We have to do something to detect system shutdown and handle it *properly*. Once we're handling it properly (i.e., alerting the user that they have unsaved mail messages, composer documents, etc.) then this bug will be fixed. There is another bug to track the bigger issue (bug 14807).
No longer depends on: 14807
This is a major defect in our most important performance work. We can't wait until 1.0 to address it. ->p1/0.9.9
Priority: -- → P1
Target Milestone: mozilla1.0 → mozilla0.9.9
from peter's last message, this sounds like it pretty important. how are we doing on it?
We need a fix for 14807, first (which may fully take care of this, too).
Depends on: 14807
Bill, Dan hasn't commented in that bug for 18 months, why don't you just take it and fix it?
Blocks: 123821
No longer blocks: 107067
He did, quietly, target it for mozilla1.0 fairly recently. It's definitely on his list, and my list is too long already.
Target Milestone: mozilla0.9.9 → mozilla1.0
re-assigning 'several bugs at once' to morse@netscape.com.
Assignee: law → morse
ADT triage team needs info: qawanted. Under what circumstances does this still happen? What is the impact on typical users?
Keywords: qawanted
Whiteboard: [need info]
I do not see this problem with Win98 or any other Win OS. Sorry- not sure what may be on Jaime's machine to cause this
removing plus for renomination. If anyone can reliably reproduce this, please get sufficient steps listed here.
Keywords: nsbeta1+nsbeta1
nsbeta1- per Nav triage team, ->1.2
No longer blocks: 108795
Keywords: nsbeta1nsbeta1-
Target Milestone: mozilla1.0 → mozilla1.2alpha
This bug also affects Mozilla add-ons, and does not allow an XPCOM service to implement a clean shutdown. The system shutdown should trigger an "xpcom-shutdown" event which services can use to shut themselves down. Enigmail is a Mozilla add-on which opens a hidden console window to run PGP/GPG. The console window is freed on an XPCOM shutdown. However, in turbo mode, this does not happen and causes Windows 98 to hang for several seconds during system shutdown. Here's the bug report: http://mozdev.org/bugs/show_bug.cgi?id=972
No longer blocks: 75599
Blocks: 75599
I'm seeing this as a regression with the 1.1-alpha builds (2002-06-11? thru 2002-06-20) on WinNT. I did not have this problem with the 1.0 branch prior to 1.1-alpha.
Component: Browser-General → QuickLaunch (AKA turbo mode)
reassigning
Assignee: morse → law
Severity: major → critical
Keywords: hang
wfm?
worksforme
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → WORKSFORME
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.