Joshua Mitchell (Inactive) Reporter
	Description • 10 years ago

Description:
The cities listed under the City picker are formatted inconsistently. Some have a country or state in front of them separated with a "/". Even cities found in the same state are listed inconsistently. 
For example:
Indiana has 8 entries with the format : Indiana/<cityname> however there are other cities in Indiana listed that are not preceded with the Indiana/
such as Indianapolis. Additionally, there is a "Knox IN" which follows yet another format of <City, State abbreviation>

This is creating double-listed cities such as "Kentucky/Louisville" AND "Louisville" even though they are the same city.

Repro Steps:
1) Update a Open C to BuildID: 20140428000206
2) Launch Settings (or FTE)
3) Proceed to date / time screen
4) Select "change" next to city
5) Scroll through the list

Actual:
Cities are listed in an inconsistent format
Expected:
The format will be consistent

1.4 Environmental Variables:
Device: Open C 1.4 MOZ
BuildID: 20140428000206
Gaia: d23e479e8a4ce0bc620acb2d7e2f82801aa4d0ea
Gecko: 36f67ce46855
Version: 30.0a2
Firmware Version: P821A10-Eng_20140410

Repro frequency: 100%
Link to failed test case:https://moztrap.mozilla.org/manage/case/6137/
See attached: City1.png, City2.png

	Joshua Mitchell (Inactive) Reporter
	Comment 2 • 10 years ago

This DOES occur on the 1.4 Buri
1.4 Environmental Variables:
Device: Open C 1.4 MOZ
BuildID: 20140428000206
Gaia: d23e479e8a4ce0bc620acb2d7e2f82801aa4d0ea
Gecko: 36f67ce46855
Version: 30.0a2
Firmware Version: P821A10-Eng_20140410

	Joshua Mitchell (Inactive) Reporter
	Comment 3 • 10 years ago

Previous post has wrong environmental variables - please use these
1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140428000206
Gaia: d23e479e8a4ce0bc620acb2d7e2f82801aa4d0ea
Gecko: 36f67ce46855
Version: 30.0a2
Firmware Version: v1.2-device.cfg

	Joshua Mitchell (Inactive) Reporter
	Comment 4 • 10 years ago

This DOES occur on the 1.3 Buri
Device: Buri 1.3 MOZ
BuildID: 20140428024001
Gaia: 32a9e3db738e0b3bc44a4d4d5c16512a2617a2cf
Gecko: d7b1e90008e5
Version: 28.0
Firmware Version: v1.2-device.cfg

	Joshua Mitchell (Inactive) Reporter
	Comment 5 • 9 years ago

This issue also occurs on Flame KK 3.0, 2.2, 2.1, and 2.0 

Device: Flame 3.0 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150304010324
Gaia: 3fc0ac309f5fb0c1fe82c12223b955a4efce27e6
Gecko: c5b90c003be8
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0


Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150304002529
Gaia: 8b4b3e4b7e7c308764f71542437fd60625ac6b75
Gecko: 2cb52b7cda5a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 2.1 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150302001220
Gaia: 5d3479fdd438412adee4452720856b6b771fe5cd
Gecko: 9bf4c663241f
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.0 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150302000457
Gaia: 366aaa19ac474dc58b79d62a91cff41756ae9dfe
Gecko: 1bd33f5447d2
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 32.0 (2.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

	Peter Bylenga [:PBylenga]
	Comment 6 • 9 years ago

NI on UX to determine if should we only display City names in this list or also include the State/Country as a prefix.

	Stephany Wilkes
	Comment 7 • 9 years ago

Flagging Jacqueline on FTE. We should fix this.

	Oliver Nelson [:oliverthor]
	Comment 8 • 9 years ago

I think I can fix this, attaching a patch file of what I've done. 
From behavior observed right now, there doesn't really call for a 'Country/City' with country listing before each city entry, since there is already a region block identifier, such as 'Americas' or 'Europe', to select from prior to city. For that reason, I've struck (for example) 'Indiana/Knox' down to 'Knox' and 'Argentina/Buenos_Aires' down to 'Buenos_Aires'.

I also added 'Seattle' as an entry in 'Americas', in an effort to feel more represented, and re-alphabetized the lists after updating these texts. :)

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 9 • 9 years ago

I'm not sure we should fix it in this manner.  The reason is because there are multiple cities with the same name like San Juan.  ie Argentina, Texas/US, Puerto Rico all have a San Juan.

We should review the cities and verify the reason for having the Countries listed.
I'm not sure if this is a bug in regards to having the country listed.

Perhaps we can have a better UX around the listings.

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 10 • 9 years ago

Comment on attachment 8596730 [details] [diff] [review]
0001-Bug-1003433-B2G-Settings-Date-Time-Cities-are-listed.patch

Review of attachment 8596730 [details] [diff] [review]:
-----------------------------------------------------------------

Review minus.  Common city names have the countries listed in some of the cases.  Not sure if that's the case with all of them.

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 11 • 9 years ago

fyi on bug/patch review.  some city names are in multiple countries.  That's one reason why the countries are listed.  Not sure if there's any other reason.

	Stephany Wilkes
	Comment 12 • 9 years ago

I'll flag Jenny on ui-review?. She owns UX for Settings.

	Jenny Lee
	Comment 13 • 9 years ago

Comment on attachment 8596730 [details] [diff] [review]
0001-Bug-1003433-B2G-Settings-Date-Time-Cities-are-listed.patch

Hi, 

As mentioned in previous comments, some city names are in multiple countries so we can't remove the prefixes. 
Thanks!

	Peter Bylenga [:PBylenga]
	Comment 14 • 9 years ago

perhaps something like at www.mozilla.org that was done for finding communities?  Attached the screenshot of how it appears.

	Peter Bylenga [:PBylenga]
	Comment 15 • 9 years ago

flagging general UX flag, Jenny's account is deactivated.

	Gervase Markham [:gerv]
	Comment 16 • 9 years ago

Er, you can't just go changing the timezone names without a proper plan. These identifiers, for all their flaws, are standard and used in many different places, and people who live in places with weird time will need to find the one that corresponds to them.

If we want to improve the UX here, we should think holistically, rather than "add Seattle for better representation". :-)

Gerv

	Dietrich Ayala (:dietrich)
	Comment 17 • 9 years ago

(In reply to Gervase Markham [:gerv] from comment #16)
> If we want to improve the UX here, we should think holistically, rather than
> "add Seattle for better representation". :-)

The goal is make sure the list is correct (according to Olsen, for example) *and* serves the users' needs.

Also, it's Portland I want to sneak in, not Seattle.

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 18 • 9 years ago

And don't forget Korea also changed their time zone : bug 1192902

	Ted Clancy [:tedders1]
	Comment 19 • 9 years ago

This issue will be improved by Bug 1201254.

	Dietrich Ayala (:dietrich)
	Comment 20 • 9 years ago

Staying assigned, will evaluate after bug 1201254 is fixed.

	Tiffanie Shakespeare [:tif]
	Comment 21 • 9 years ago

Is this another dup? Slightly different but same general idea.

https://bugzilla.mozilla.org/show_bug.cgi?id=1177416

	Tiffanie Shakespeare [:tif]
	Comment 22 • 9 years ago

Removing NI - trying to get the related bug fixed.

	Dietrich Ayala (:dietrich)
	Comment 23 • 9 years ago

De-assigning myself. Bug 1201254 doesn't even have an assignee, so I'm not going to hang on to this one.

	BMO Automation
	Comment 24 • 6 years ago

Firefox OS is not being worked on