Closed
Bug 1003608
Opened 11 years ago
Closed 9 years ago
Indicate locally visited pages in Remote Tabs
Categories
(Firefox for Android Graveyard :: Android Sync, enhancement)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: rnewman, Unassigned, Mentored)
References
Details
(Whiteboard: [lang=java][good next bug])
If you have multiple tabs open on a topic in a remote device, the experience in Fennec is less than ideal -- you see a kinda truncated title (Bug 852592), and opening the tab to check it out is a lot of context switching.
(This is particularly painful if you're trying to find a tab you haven't already visited locally. Just as with Bug 846569, the tab list jumps back to the start every time you open a tab.)
I think it's worth tracking which history items were visited on this device, and visually distinguishing them in the Remote Tabs list.
This is something we probably need for future Sync improvements, anyway (discrete remote and local history).
Reporter | ||
Comment 1•11 years ago
|
||
(In reply to Richard Newman [:rnewman] from comment #0)
> (This is particularly painful if you're trying to find a tab you haven't
> already visited locally. Just as with Bug 846569, the tab list jumps back to
> the start every time you open a tab.)
Filed Bug 1003610 for this.
Comment 2•11 years ago
|
||
This is an interesting second or third bug. What will need to happen is that before [1], we'll need to save a copy of the currently opened tabs, and near [1], we'll need to check (based on URI, I think) whether the remote tab is currently open. Adding that bit (boolean value) of information to the tab HashMap is the first part.
The second part of this ticket will be changing the visual style of a tab with that bit set. I'm going to ask ibarlow for UX input, but for now, let's try making the title and URI darker grey. You'll need to edit the styles [2]. In fact, a little reading suggests this is really tricky; see [3]. So maybe this ticket is a tough second bug :)
[1] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tabspanel/RemoteTabsList.java#105
[2] See
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/remote_tabs_child.xml?force=1
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout-xlarge-v11/remote_tabs_child.xml?force=1
[3] http://stackoverflow.com/a/16986935
Whiteboard: [mentor=nalexander][lang=java][good second bug]
Reporter | ||
Comment 3•11 years ago
|
||
It's actually more than that -- we don't just care if it's open in a local tab (that works for desktop, not so much on mobile where users keep fewer tabs open).
We also care about your history, and we want to distinguish between local and remote history (because of course the remote tab has been visited, just not on this device!).
So this involves a ContentProvider migration/schema change to improve history representation, which isn't necessarily a good second bug. Feel free to split that out and assign it to me, though! The UI change should be straightforward.
Comment 4•10 years ago
|
||
(In reply to Richard Newman [:rnewman] from comment #3)
> It's actually more than that -- we don't just care if it's open in a local
> tab (that works for desktop, not so much on mobile where users keep fewer
> tabs open).
Not addressing the greater thing, but addressing this case -- we have code for showing a tab icon and "switch to tab" around http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/home/TwoLinePageRow.java#169. It's used in the bookmarks home pager. We should probably use this two line row thing in remote tabs.
Assignee | ||
Updated•10 years ago
|
Mentor: nalexander
Whiteboard: [mentor=nalexander][lang=java][good second bug] → [lang=java][good second bug]
Comment 5•10 years ago
|
||
Whiteboard: [lang=java][good second bug] → [lang=java][good next bug]
Comment 6•9 years ago
|
||
Since we're considering merging this page with our other home panels, is this still worth doing, Nick?
Flags: needinfo?(nalexander)
Comment 7•9 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #6)
> Since we're considering merging this page with our other home panels, is
> this still worth doing, Nick?
I think most of this will be subsumed by showing "switch to tab", like we already do, and Bug 1227021 more broadly.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(nalexander)
Resolution: --- → WONTFIX
Updated•7 years ago
|
Product: Android Background Services → Firefox for Android
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•