Closed
Bug 1003843
Opened 11 years ago
Closed 10 years ago
Follow up to Bug 951676 - [Messages][Refresh] Add specific image in case of more than one recipient in the list threads
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(feature-b2g:2.2+, tracking-b2g:backlog)
RESOLVED
FIXED
2.1 S6 (10oct)
People
(Reporter: noemi, Assigned: azasypkin)
References
Details
(Whiteboard: groupmms [p(2.1S6)=1][p(2.1S5)=1])
Attachments
(7 files, 1 obsolete file)
Follow up to Bug 951676 to track the following scenario:
4. When we have more than one recipient associated with the message -> A circle with the number of recipients of that message will be shown.
ni to visual design team to provide specs for this. Thanks!
Flags: needinfo?(vpg)
Comment 1•11 years ago
|
||
Find attached the visual mockup and spec of how multiple recipients' thread should look in the messages inbox screen.
Flags: needinfo?(vpg)
Comment 2•11 years ago
|
||
Comment 3•11 years ago
|
||
Updated•11 years ago
|
blocking-b2g: --- → backlog
feature-b2g: --- → 2.0
Updated•11 years ago
|
blocking-b2g: backlog → 2.0?
feature-b2g: 2.0 → ---
Updated•10 years ago
|
Whiteboard: groupmms
Updated•10 years ago
|
Blocks: sms-refresh-v2.1
Updated•10 years ago
|
Comment 5•10 years ago
|
||
This was taken as VR for 2.1 and in planned sprint.
So I'm replacing the 2.1? by feature-b2g.
blocking-b2g: 2.1? → backlog
feature-b2g: --- → 2.1
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
QA Contact: azasypkin
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → azasypkin
QA Contact: azasypkin
Assignee | ||
Comment 6•10 years ago
|
||
Hey Fang,
Here is the screenshot of the inbox panel that contains threads with multiple recipients. I'd like to confirm with you following points:
1. We display multiple recipients indicator for the any message draft with multiple recipients and for the non-draft MMS with multiple recipients. Right?
2. As per attached spec title for the thread with multiple recipients has the following format "first_contact_name_or_number + remaining_number_of_recipients". Currently we use another format "first_contact_name_or_number (+remaining_number_of_recipients)". Should we leave round brackets for number of recipients as it was before?
Thanks!
Attachment #8461808 -
Flags: ui-review?(fshih)
Hello Oleg, after discussion with Fang, think I can answer your questions!
1. We will display the "+3" recipient number indicator after contact name (or number). We will NOT be showing the "round icon with total recipient number on it" on the right side, instead, to align the design when there's only one recipient, we want to use a avatar-like picture that suggests there are multiple people in the conversation.
2. We'd like to make 2 changes to the current design, first, remove the brackets. Second, try to show the name of 2nd, 3rd (and so on so forth) recipient when possible. This is to give user more info on who's in the conversation on the inbox level, because on the conversation/thread view page, we only show the first contact info. Possible combinations:
a) when there's only enough space to show one contact name
first_contact_name_or_number + remaining_number_of_recipients
ex. Wilfred Mathanaraj +3
b) when there's enough space to show one contact name and part of second contact name
first_contact_name_or_number + "," + second_contact_name_or_number (partial) + "..." + remaining_number_of_recipients
ex. Jenny Lee, Fang... +2
c) when there's enough space to show two full contact names
first_contact_name_or_number + "," + second_contact_name_or_number + remaining_number_of_recipient
ex. Jenny Lee, Ray Ma +3
Fang will provide a visual to better explain the idea and define the space used for displaying contact name/number. Let me know if there's any problem, thanks!
Comment 8•10 years ago
|
||
Comment on attachment 8461808 [details]
Multiple recipients thread
I will attached the visual spec asap. Thanks!
Attachment #8461808 -
Flags: ui-review?(fshih) → ui-review-
Assignee | ||
Comment 9•10 years ago
|
||
As we're waiting for the new spec, reassigned for now.
Assignee: azasypkin → nobody
Status: ASSIGNED → NEW
Comment 10•10 years ago
|
||
Hi Fang, do we have any update about the new visual spec for multiple recipient in thread list view?
Flags: needinfo?(fshih)
Comment 11•10 years ago
|
||
Hi,
Attached the new visual spec.
Spec includes:
* multiple recipients layout
* message draft with multiple recipients
* No contact image
* No recipient
The default image Sabrina is still working on it.
The image is going to work for the entire system, so it'll take some times.
Let me know if you have any other questions about the spec, Thanks!
Flags: needinfo?(fshih)
Updated•10 years ago
|
QA Whiteboard: [COM=Gaia::SMS]
Comment 12•10 years ago
|
||
Per product prioritization, this could be 2.2 focus.
feature-b2g: 2.1 → 2.2
Updated•10 years ago
|
Target Milestone: 2.1 S1 (1aug) → ---
Updated•10 years ago
|
No longer blocks: sms-refresh-v2.1
Updated•10 years ago
|
Blocks: sms-sprint-2.1S5
Updated•10 years ago
|
Target Milestone: --- → 2.1 S5 (26sep)
Updated•10 years ago
|
Assignee: nobody → felash
Comment 16•10 years ago
|
||
Fang, can you please give some guidance about how to use this image?
* IIRC we don't need to use it for contacts without pictures. Or do we?
* do we always use it at the top-left position?
Also, can you try to compress the assets a little more?
Thanks !
Flags: needinfo?(fshih)
Comment 18•10 years ago
|
||
Hi Julien,
We'll use it for contacts without pictures now on. And For image position, we want to place it in random, So the pattern won't look all the same.
Also the assets have newer version again. I already compressed the new assets.
Currently Carol is working on all the default image for entire system with Pavel. For contact photo is in bug 1069820. Incase you need to know, since this is also contact default image. Let me know if you need anything else. Thanks!
Attachment #8489898 -
Attachment is obsolete: true
Flags: needinfo?(fshih)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → azasypkin
Status: NEW → ASSIGNED
Assignee | ||
Comment 19•10 years ago
|
||
Assignee | ||
Comment 20•10 years ago
|
||
Hey Fang,
Could you please let us know if we should display default image for the 1-to-1 threads with numbers that user doesn't have in Contacts (aka unknown numbers)?
Thanks!
Flags: needinfo?(fshih)
Comment 21•10 years ago
|
||
(In reply to Oleg Zasypkin [:azasypkin] from comment #20)
> Hey Fang,
>
> Could you please let us know if we should display default image for the
> 1-to-1 threads with numbers that user doesn't have in Contacts (aka unknown
> numbers)?
>
> Thanks!
We're thinking not display anything in this case.
So we have only two cases when we don't display anything:
1. Draft without recipient
2. Thread with a number that isn't in contacts.
Thanks! :)
Flags: needinfo?(fshih)
Assignee | ||
Comment 22•10 years ago
|
||
Comment on attachment 8495759 [details]
GitHub pull request URL
Hey Julien,
Can I ask for your early feedback here? I have some concerns that I've left on GitHub.
Thanks!
Attachment #8495759 -
Flags: feedback?(felash)
Comment 23•10 years ago
|
||
Comment on attachment 8495759 [details]
GitHub pull request URL
Looks good to me :)
some comments on github but it should be ready soon !
Attachment #8495759 -
Flags: feedback?(felash) → feedback+
Updated•10 years ago
|
Blocks: sms-sprint-2.1S6
Whiteboard: groupmms [p=1] → groupmms [p(2.1S6)=1][p(2.1S5)=1]
Target Milestone: 2.1 S5 (26sep) → 2.1 S6 (10oct)
Assignee | ||
Comment 24•10 years ago
|
||
Comment on attachment 8495759 [details]
GitHub pull request URL
Hey Julien,
Here are some more fixes and generator syntax instead of recursive Promise chain.
Could you please take a look?
Thanks!
Attachment #8495759 -
Flags: review?(felash)
Comment 25•10 years ago
|
||
Comment on attachment 8495759 [details]
GitHub pull request URL
r=me with the comments handled.
In case you want a second look for your additional changes, please ask Steve :)
Attachment #8495759 -
Flags: review?(felash) → review+
Assignee | ||
Comment 26•10 years ago
|
||
Comment on attachment 8495759 [details]
GitHub pull request URL
Hey Steve,
Since Julien is on PTO, could you please have a quick look at the latest commit in PR to be sure that everything is fine :)
Thanks!
Attachment #8495759 -
Flags: review+ → review?(schung)
Comment 27•10 years ago
|
||
Comment on attachment 8495759 [details]
GitHub pull request URL
Looks great! It's nice to see more feature and new utils invented :)
Attachment #8495759 -
Flags: review?(schung) → review+
Assignee | ||
Comment 28•10 years ago
|
||
(In reply to Steve Chung [:steveck] from comment #27)
> Comment on attachment 8495759 [details]
> GitHub pull request URL
>
> Looks great! It's nice to see more feature and new utils invented :)
Thanks for review!
Master: https://github.com/mozilla-b2g/gaia/commit/d5a7b209931e4d698dad865d57616d3235dacab7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Flags: in-moztrap?(echang)
Comment 31•10 years ago
|
||
Updated•10 years ago
|
Flags: in-moztrap?(echang) → in-moztrap+
Updated•10 years ago
|
Attachment #8558337 -
Attachment mime type: text/plain → text/html
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•