Closed
Bug 1004329
Opened 11 years ago
Closed 10 years ago
[Flatfish][Homescreen] Returning home (landscape) from portrait app causes app icons to misalign/overlap
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Firefox OS Graveyard
Gaia::Homescreen
Tracking
(tracking-b2g:backlog)
RESOLVED
FIXED
tracking-b2g | backlog |
People
(Reporter: cory.gack, Assigned: yifan)
References
Details
(Keywords: verifyme, Whiteboard: [Flatfish][TCP=breakage])
Attachments
(4 files)
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140428193813
Steps to reproduce:
on flatfish device open a portrait app (Marketplace).
Use home gesture to return to Homescreen.
swipe to another homescreen.
Actual results:
The spacing of the app icons is overlapped. items from screen 2 are on screen 3 and placed between screen 2's items
Expected results:
spacing and screens stay the same after returning to homescreen
Are you sure you have used a real Flatfish device (UA seems to be Firefox OS simulator on Firefox linux)
I can't reproduce the issue with a real Flatfish device.
Need more info.
B2G: 1.4.0.0-prerelease
User Agent: Mozilla/5.0 (Tablet; rv:29.0) Gecko/29.0Firefox/29.0
Flags: needinfo?(cory.gack)
Reporter | ||
Comment 2•11 years ago
|
||
(In reply to cyke64 from comment #1)
> Are you sure you have used a real Flatfish device (UA seems to be Firefox OS
> simulator on Firefox linux)
> I can't reproduce the issue with a real Flatfish device.
> Need more info.
>
> B2G: 1.4.0.0-prerelease
> User Agent: Mozilla/5.0 (Tablet; rv:29.0) Gecko/29.0Firefox/29.0
Yes it was a real Flatfish device, however I entered the bug through Firefox on Linux. I should add that it was a fresh build from the master branch using the command:
GAIA_DISTRIBUTION_DIR=distribution_tablet B2G_SYSTEM_APPS=1 B2G_UPDATER=1 ./build.sh
Flags: needinfo?(cory.gack)
Gary,
Is Master branch based on B2G 2.0 ? So it's normal I can't reproduce the issue with 1.4
Comment 4•10 years ago
|
||
I can confirm this bug in my tablet using FirefoxOS 2.0
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 5•10 years ago
|
||
I know we can't take screenshots at the moment but are you able to pull out he camera on your phone or something we have a visual attachment for this bug?
Comment 6•10 years ago
|
||
(In reply to Andrew Truong [:feer56] from comment #5)
> I know we can't take screenshots at the moment but are you able to pull out
> he camera on your phone or something we have a visual attachment for this
> bug?
I'm attaching two digital photos of the issue so you can see it.
Comment 7•10 years ago
|
||
Comment 8•10 years ago
|
||
Comment 9•10 years ago
|
||
Hmmm.. I'll need to check on my device but I'm pretty sure that this didn't occur on 1.4. Maybe this is a 2.0+ thing?
I'll put a needinfo on myself to go check.
Flags: needinfo?(feer56)
Comment 10•10 years ago
|
||
Alright. This definitely does seems like a 2.0 issue only. I can't reproduce on current 1.4 that comes with this tablet.
blocking-b2g: --- → 2.0?
Flags: needinfo?(feer56)
Comment 12•10 years ago
|
||
I can reproduce this on the v1.4 branch as well (but not on v1.3).
Comment 13•10 years ago
|
||
I can reproduce it on the latest 2.1 stable build as well.
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → yliao
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 14•10 years ago
|
||
When the marketplace is closed, the mediaQueryListener in ScreenHelper is fired twice. The first one sees the document as Portrait and set the width and height wrong. The second one does nothing and leaves the width and height unchanged.
Attachment #8460129 -
Flags: review?(21)
Updated•10 years ago
|
Whiteboard: [Flatfish]
Attachment #8460129 -
Flags: review?(21) → review?(crdlc)
Updated•10 years ago
|
Whiteboard: [Flatfish] → [Flatfish][TCP=breakage]
Updated•10 years ago
|
Comment 16•10 years ago
|
||
Comment on attachment 8460129 [details]
pull request
Just a comment on github, it looks good, thx
Attachment #8460129 -
Flags: review?(crdlc) → review+
Comment 17•10 years ago
|
||
I can't reproduce the bug in the August 15 FFOS 2.1 build. Could someone please confirm?
Assignee | ||
Comment 18•10 years ago
|
||
Tried it on the latest master build. It can still be reproduced.
Assignee | ||
Comment 19•10 years ago
|
||
Merged into master
https://github.com/mozilla-b2g/gaia/pull/22025
TBPL
https://tbpl.mozilla.org/?rev=e6cf9fe3c72ba63169312dc2bdf9fcb42b060dc4&tree=Gaia-Try
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 20•10 years ago
|
||
Tried it on the latest 20140829 (007f3c50) build on my Flatfish, it can still be reproduced.
Flags: needinfo?(yliao)
Assignee | ||
Comment 21•10 years ago
|
||
I couldn't reproduce it on
Gaia 007f3c50cf69f044628a23c2376c6d88aa45f617
Gecko 6ea8870876e62b440ed3c54c86ff6be9055d5015
BuildID 20140829012624
Version 34.0a1
ro.build.version.incremental=20140829
ro.build.date=Fri Aug 29 01:15:44 CST 2014
Could you please describe the steps to reproduce it? Thank you.
Flags: needinfo?(yliao)
Comment 22•10 years ago
|
||
(In reply to Yi-Fan Liao [:yifan][:yliao] from comment #21)
> Could you please describe the steps to reproduce it? Thank you.
Boot tablet, same steps with comment 0.
Note: maybe need repeat the operations several times to reproduce.
Tried on 20140829-0115, 2014082901264, git commit 007f3c50.
Comment 23•10 years ago
|
||
Another steps to reproduce: open a landscape app, switch to the portrait mode (to erected), return to homescreen, swipe to another homescreen, the issue occur.
Assignee | ||
Comment 24•10 years ago
|
||
Thank you. I tried it a dozen times but still failed to reproduce it. Downloaded apps from marketplace, tried several landscape app with your suggestion but neither displayed the overlap. Could you please record a video with the steps to reproduce the bug? In the meantime I'll see what I probably missed in the code.
Comment 25•10 years ago
|
||
(In reply to Yi-Fan Liao [:yifan][:yliao] from comment #24)
> Thank you. I tried it a dozen times but still failed to reproduce it.
> Downloaded apps from marketplace, tried several landscape app with your
> suggestion but neither displayed the overlap. Could you please record a
> video with the steps to reproduce the bug? In the meantime I'll see what I
> probably missed in the code.
Thank you for reply, but I don't have a suitable device to record the real tablet now :(
Do you know another ways to record the screen in Firefox OS device? or another dump or instructions ways to helpful you.
Assignee | ||
Comment 26•10 years ago
|
||
Some use a cellphone or camera to record it and upload the video to either youtube or bugzilla. Bug 1047875 looks like a similar problem, I assume it also happens on your device?
Flags: needinfo?(yfdyh000)
Comment 28•10 years ago
|
||
With a bit more testing, it is hard to get it to misalign but it did happen; but once again it's a very rare case imo.
Comment 29•10 years ago
|
||
(In reply to Yi-Fan Liao [:yifan][:yliao] from comment #26)
> Some use a cellphone or camera to record it and upload the video to either
> youtube or bugzilla. Bug 1047875 looks like a similar problem, I assume it
> also happens on your device?
Unfortunately, I really don't have an suitable recording video device.
No, I have never seen bug 1047875. but I continue to see this bug and bug 1053685 on build 20140829 (007f3c50).
I'll try to flash the latest build as soon and test.
Flags: needinfo?(yfdyh000)
Assignee | ||
Comment 30•10 years ago
|
||
chens has helped reproduced a very similar issue like this. With dev apps installed on flatfish, we could still see apps overlaped after returning from portrait apps.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 31•10 years ago
|
||
After looking up bug 991906 and its file changes https://github.com/mozilla-b2g/gaia/pull/18516/files , I think it's safe to remove the MediaQueryListEventHandler.
The original problem of bug 991906 is when orientation changes from apps to the homescreen, window.innerWidth handled by the Gaia system app is incorrect (see https://bugzilla.mozilla.org/show_bug.cgi?id=991906#c29 ).
In bug 991906 caching the original width of the homescreen was proposed and implemented. However the code still requests for new screen.width while the orientation is change to portrait, this seems unnecessary though it works on flame but not on flatfish.
I'll revert my previous commit and remove the orientation change handler.
Assignee | ||
Comment 32•10 years ago
|
||
Backout commit a003ff47ad6f6c558ac7290b40980d71ceb6d358
Assignee | ||
Comment 33•10 years ago
|
||
Attachment #8483217 -
Flags: review?(crdlc)
Comment 34•10 years ago
|
||
Comment on attachment 8483217 [details]
pull request
LGTM, just a comment on github
Attachment #8483217 -
Flags: review?(crdlc) → review+
Assignee | ||
Comment 35•10 years ago
|
||
Merged into master
https://github.com/mozilla-b2g/gaia/pull/23657
TBPL
https://tbpl.mozilla.org/?rev=ede20c8d8bf535e6166a95522226554a7132e973&tree=Gaia-Try
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•