Closed
Bug 1005245
Opened 11 years ago
Closed 11 years ago
Review unreviewed changes at start of loop-service branch
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Whiteboard: [est: 0.5d][p=.5][s=mlpnightly1])
Attachments
(1 file)
|
(deleted),
patch
|
NiKo
:
review+
|
Details | Diff | Splinter Review |
There's a set of unreviewed changes at the start of the loop-service branch, that we should go through and do review on and add any necessary changes, before we can land these.
https://github.com/adamroach/gecko-dev/compare/ad5ea12...203d747
I'll do that early next week.
|
||
Updated•11 years ago
|
Whiteboard: [est: 0.5d] → [est: 0.5d][p=.5][s=mlpnightly2]
|
||
Comment 1•11 years ago
|
||
Suggest we move this bug from mlpnightly1 to mlpnightly1, as we won't be allowed to land this code if it hasn't been reviewed.
Whiteboard: [est: 0.5d][p=.5][s=mlpnightly2] → [est: 0.5d][p=.5][s=mlpnightly1]
|
Assignee | |
Comment 2•11 years ago
|
||
This came out of the review on bug 972020, which was the unreviewed changesets on the branch.
We don't need these bits of the harness since we changed our privilege model, and also stopped using the version of l10n.js that needed FirefoxCom.
Attachment #8422351 -
Flags: review?(nperriault)
Comment on attachment 8422351 [details] [diff] [review]
Remove now redundant test harness code
Review of attachment 8422351 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8422351 -
Flags: review?(nperriault) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Landed on integration branch, pending move to mercurial:
https://github.com/adamroach/gecko-dev/commit/8eaf4c56010f9a2a8ce00fba355ffbcf2fbc4f48
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
|
Assignee | |
Comment 6•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Target Milestone: mozilla32 → mozilla33
Untracking for QA. Please needinfo me to request testing.
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•