Closed Bug 1005375 Opened 11 years ago Closed 11 years ago

Add an API that allows CryptoTasks to be created without being dispatched

Categories

(Core :: Security: PSM, defect)

Product:
Core
Component:
Security: PSM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla32

People

(Reporter: rbarnes, Assigned: rbarnes)

References

Details

Attachments

(1 file)

bug-1005375.patch r=dkeeler
(deleted), patch
keeler
: review+
Details | Diff | Splinter Review
Right now, if a CryptoTask is created, but its Dispatch method is never called, then the ReleaseNSSResources method will never be called, and it will hit an assertion in its destructor. We should have an API that allows subclasses or calling code to say create a CryptoTask, but then not call Dispatch (e.g., if there's an error in the construction).
Component: Security → Security: PSM
Assignee: nobody → rlb
Attached patch bug-1005375.patch r=dkeeler (deleted) — — Splinter Review
* Add a Skip() method to skip running the actual task * Add a comment noting at Dispatch() or Skip() must be called
Attachment #8416910 - Flags: review?(dkeeler)
Comment on attachment 8416910 [details] [diff] [review] bug-1005375.patch r=dkeeler Review of attachment 8416910 [details] [diff] [review]: ----------------------------------------------------------------- Ok - I think this will work. r=me.
Attachment #8416910 - Flags: review?(dkeeler) → review+
Attachment #8416910 - Attachment description: bug-1005375.patch → bug-1005375.patch r=dkeeler
Keywords: checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3604a7162515
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: