Closed
Bug 1006139
Opened 11 years ago
Closed 11 years ago
Contacts getAll caching is broken
Categories
(Core Graveyard :: DOM: Contacts, defect)
Tracking
(blocking-b2g:1.4+, firefox30 wontfix, firefox31 wontfix, firefox32 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
References
Details
Attachments
(1 file)
(deleted),
patch
|
gwagner
:
review+
|
Details | Diff | Splinter Review |
ContactDispatcher calls Array.splice which modifies the array it receives... Other code assumes that the array is unmodified and stores it away for later use. This leads to badness.
Also, we were calling a failure callback when we meant to be calling a success callback...
Attachment #8417655 -
Flags: review?(anygregor)
Updated•11 years ago
|
Attachment #8417655 -
Flags: review?(anygregor) → review+
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
This is required to land bug 980549.
Blocks: 980549
blocking-b2g: --- → 1.4?
Comment 4•11 years ago
|
||
Oh wow. Nice catch… Took me a while to realize what was going on because of the asyncness of the code/bug.
Assignee | ||
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
nasty bug !
Why is it necessary to land bug 980549 ?
Also, why no tests ?
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Julien Wajsberg [:julienw] (away until 5th May) from comment #6)
> Why is it necessary to land bug 980549 ?
> Also, why no tests ?
Well, the fix for bug 980549 causes test_getAllContacts.html to go orange, so we can't land bug 980549 without this, and we then do have test coverage :)
Comment 8•11 years ago
|
||
Assignee: nobody → bent.mozilla
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Comment 9•11 years ago
|
||
status-b2g-v1.4:
--- → fixed
status-b2g-v2.0:
--- → fixed
status-firefox30:
--- → wontfix
status-firefox31:
--- → wontfix
status-firefox32:
--- → fixed
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•