Closed
Bug 1006612
Opened 10 years ago
Closed 10 years ago
CSP in C++: content/base/test/csp/test_bug836922_npolicies.html fails/crashes
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
DUPLICATE
of bug 994322
People
(Reporter: ckerschb, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
I am assuming the new CSP implementation is not causing the problem, but rather showing that there is a problem :-). Not having closely investigated the problem it seems like a race condition that causes the test to fail, but why is it crashing? Here is the link to try:
https://tbpl.mozilla.org/?tree=Try&rev=cfaa5b481852
Also, pasting parts of the summary in case the TBPL log disappears:
Summary:
181 INFO TEST-UNEXPECTED-FAIL | /tests/content/base/test/csp/test_bug836922_npolicies.html | Received (0/1) enforced-policy reports for css_examplecom
185 INFO TEST-UNEXPECTED-FAIL | /tests/content/base/test/csp/test_bug836922_npolicies.html | Received (0/1) enforced-policy reports for img_self
189 INFO TEST-UNEXPECTED-FAIL | /tests/content/base/test/csp/test_bug836922_npolicies.html | Received (0/1) enforced-policy reports for img_examplecom
190 INFO TEST-UNEXPECTED-FAIL | /tests/content/base/test/csp/test_bug836922_npolicies.html | Received (0/1) report-only-policy reports for img_examplecom
194 INFO TEST-UNEXPECTED-FAIL | /tests/content/base/test/csp/test_bug836922_npolicies.html | Received (0/1) report-only-policy reports for script_self
05-06 03:36:43.720 742 742 I GeckoDump: 181 INFO TEST-UNEXPECTED-FAIL | /tests/content/base/test/csp/test_bug836922_npolicies.html | Received (0/1) enforced-policy reports for css_examplecom
05-06 03:36:43.739 742 742 I GeckoDump: 185 INFO TEST-UNEXPECTED-FAIL | /tests/content/base/test/csp/test_bug836922_npolicies.html | Received (0/1) enforced-policy reports for img_self
05-06 03:36:43.779 742 742 I GeckoDump: 189 INFO TEST-UNEXPECTED-FAIL | /tests/content/base/test/csp/test_bug836922_npolicies.html | Received (0/1) enforced-policy reports for img_examplecom
05-06 03:36:43.779 742 742 I GeckoDump: 190 INFO TEST-UNEXPECTED-FAIL | /tests/content/base/test/csp/test_bug836922_npolicies.html | Received (0/1) report-only-policy reports for img_examplecom
05-06 03:36:43.810 742 742 I GeckoDump: 194 INFO TEST-UNEXPECTED-FAIL | /tests/content/base/test/csp/test_bug836922_npolicies.html | Received (0/1) report-only-policy reports for script_self
05-06 03:55:27.409 692 692 F libc : Fatal signal 11 (SIGSEGV) at 0x00000000 (code=1)
This usually indicates the B2G process has crashed
=============
20:56:43 INFO - 05-06 03:55:23.519 742 742 I GeckoDump: 1567 INFO Todo: 64
20:56:43 INFO - 05-06 03:55:23.529 742 742 I GeckoDump: 1568 INFO Slowest: 67923ms - /tests/content/base/test/test_CrossSiteXHR_cache.html
20:56:43 INFO - 05-06 03:55:23.559 742 742 I GeckoDump: 1569 INFO SimpleTest FINISHED
20:56:43 INFO - 05-06 03:55:23.590 742 742 I GeckoDump: 1570 INFO TEST-INFO | Ran 1 Loops
20:56:43 INFO - 05-06 03:55:23.590 742 742 I GeckoDump: 1571 INFO SimpleTest FINISHED
20:56:43 INFO - 05-06 03:55:26.339 692 692 I Gecko :
20:56:43 INFO - 05-06 03:55:26.339 692 692 I Gecko : ###!!! [Child][DispatchAsyncMessage] Error: Route error: message sent to unknown actor ID
20:56:43 INFO - 05-06 03:55:26.339 692 692 I Gecko :
20:56:43 INFO - 05-06 03:55:26.349 692 692 I Gecko :
20:56:43 INFO - 05-06 03:55:26.349 692 692 I Gecko : ###!!! [Child][DispatchAsyncMessage] Error: Route error: message sent to unknown actor ID
20:56:43 INFO - 05-06 03:55:26.349 692 692 I Gecko :
20:56:43 INFO - 05-06 03:55:26.349 692 692 I Gecko :
20:56:43 INFO - 05-06 03:55:26.349 692 692 I Gecko : ###!!! [Child][DispatchAsyncMessage] Error: Route error: message sent to unknown actor ID
20:56:43 INFO - 05-06 03:55:26.349 692 692 I Gecko :
20:56:43 INFO - 05-06 03:55:26.349 692 692 I Gecko :
20:56:43 INFO - 05-06 03:55:26.349 692 692 I Gecko : ###!!! [Child][DispatchAsyncMessage] Error: Route error: message sent to unknown actor ID
20:56:43 INFO - 05-06 03:55:26.349 692 692 I Gecko :
20:56:43 INFO - 05-06 03:55:26.349 692 692 I Gecko :
20:56:43 INFO - 05-06 03:55:26.349 692 692 I Gecko : ###!!! [Child][DispatchAsyncMessage] Error: Route error: message sent to unknown actor ID
20:56:43 INFO - 05-06 03:55:26.349 692 692 I Gecko :
20:56:43 INFO - 05-06 03:55:26.349 692 692 I Gecko :
20:56:43 INFO - 05-06 03:55:26.349 692 692 I Gecko : ###!!! [Child][DispatchAsyncMessage] Error: Route error: message sent to unknown actor ID
20:56:43 INFO - 05-06 03:55:26.349 692 692 I Gecko :
20:56:43 INFO - 05-06 03:55:26.359 692 692 I Gecko :
20:56:43 INFO - 05-06 03:55:26.359 692 692 I Gecko : ###!!! [Child][DispatchAsyncMessage] Error: Route error: message sent to unknown actor ID
20:56:43 INFO - 05-06 03:55:26.359 692 692 I Gecko :
20:56:43 INFO - 05-06 03:55:26.359 692 692 I Gecko :
20:56:43 INFO - 05-06 03:55:26.359 692 692 I Gecko : ###!!! [Child][DispatchAsyncMessage] Error: Route error: message sent to unknown actor ID
20:56:43 INFO - 05-06 03:55:26.359 692 692 I Gecko :
20:56:43 INFO - 05-06 03:55:26.630 692 692 I Gecko : -*- NetworkService: NetworkService shutdown
20:56:43 INFO - 05-06 03:55:27.019 692 692 I Gonk : RIL[0]: OnDisconnect
20:56:43 INFO - 05-06 03:55:27.049 692 692 I GonkMemoryPressure: Observed XPCOM shutdown.
20:56:43 ERROR - 05-06 03:55:27.409 692 692 F libc : Fatal signal 11 (SIGSEGV) at 0x00000000 (code=1)
20:56:43 ERROR - This usually indicates the B2G process has crashed
20:56:43 INFO - 05-06 03:55:27.930 37 37 I DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
20:56:43 INFO - 05-06 03:55:27.930 37 37 I DEBUG : Build fingerprint: 'Android/full/generic:4.0.4.0.4.0.4/OPENMASTER/eng.cltbld.20140505.143814:eng/test-keys'
20:56:43 INFO - 05-06 03:55:27.930 37 37 I DEBUG : pid: 692, tid: 692 >>> /system/b2g/b2g <<<
20:56:43 INFO - 05-06 03:55:27.940 37 37 I DEBUG : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 00000000
20:56:43 INFO - 05-06 03:55:27.940 37 37 I DEBUG : r0 00000000 r1 5a5a5a5a r2 00000000 r3 00000000
20:56:43 INFO - 05-06 03:55:27.940 37 37 I DEBUG : r4 43d8d240 r5 42510754 r6 43db0014 r7 000000a0
20:56:43 INFO - 05-06 03:55:27.940 37 37 I DEBUG : r8 00001000 r9 00000000 10 42511630 fp 0000000c
20:56:43 INFO - 05-06 03:55:27.940 37 37 I DEBUG : ip 4003ef0c sp beafea60 lr 40d6ec11 pc 00000000 cpsr 60000010
20:56:43 INFO - 05-06 03:55:27.940 37 37 I DEBUG : d0 0000000000000000 d1 4098334b7149f2ca
20:56:43 INFO - 05-06 03:55:27.950 37 37 I DEBUG : d2 3a4f8f12bea5fb7d d3 0000000000000000
20:56:43 INFO - 05-06 03:55:27.950 37 37 I DEBUG : d4 0917d76000000000 d5 4030000000000000
20:56:43 INFO - 05-06 03:55:27.950 37 37 I DEBUG : d6 40cf400000000000 d7 00003e8000000000
20:56:43 INFO - 05-06 03:55:27.950 37 37 I DEBUG : d8 0000000000000000 d9 0000000000000000
20:56:43 INFO - 05-06 03:55:27.950 37 37 I DEBUG : d10 0000000000000000 d11 0000000000000000
20:56:43 INFO - 05-06 03:55:27.950 37 37 I DEBUG : d12 0000000000000000 d13 0000000000000000
20:56:43 INFO - 05-06 03:55:27.950 37 37 I DEBUG : d14 0000000000000000 d15 0000000000000000
20:56:43 INFO - 05-06 03:55:27.950 37 37 I DEBUG : scr 68000013
20:56:43 INFO - 05-06 03:55:27.950 37 37 I DEBUG :
20:56:43 INFO - 05-06 03:55:28.299 37 37 I DEBUG : #00 pc 00000000
20:56:43 INFO - 05-06 03:55:28.309 37 37 I DEBUG : #01 pc 00426c0e /system/b2g/libxul.so
20:56:43 INFO - 05-06 03:55:28.309 37 37 I DEBUG : #02 pc 004297e8 /system/b2g/libxul.so
20:56:43 INFO - 05-06 03:55:28.319 37 37 I DEBUG : #03 pc 00429808 /system/b2g/libxul.so
20:56:43 INFO - 05-06 03:55:28.319 37 37 I DEBUG : #04 pc 004eefa2 /system/b2g/libxul.so
20:56:43 INFO - 05-06 03:55:28.319 37 37 I DEBUG : #05 pc 004eefd0 /system/b2g/libxul.so
20:56:43 INFO - 05-06 03:55:28.319 37 37 I DEBUG : #06 pc 0043a088 /system/b2g/libxul.so
20:56:43 INFO - 05-06 03:55:28.330 37 37 I DEBUG : #07 pc 0001ec02 /system/lib/libc.so (__cxa_finalize)
20:56:43 INFO - 05-06 03:55:28.330 37 37 I DEBUG : #08 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.330 37 37 I DEBUG : #09 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.330 37 37 I DEBUG : #10 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.339 37 37 I DEBUG : #11 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.339 37 37 I DEBUG : #12 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.339 37 37 I DEBUG : #13 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.339 37 37 I DEBUG : #14 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.349 37 37 I DEBUG : #15 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.349 37 37 I DEBUG : #16 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.349 37 37 I DEBUG : #17 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.349 37 37 I DEBUG : #18 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.359 37 37 I DEBUG : #19 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.359 37 37 I DEBUG : #20 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.359 37 37 I DEBUG : #21 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.359 37 37 I DEBUG : #22 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.370 37 37 I DEBUG : #23 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.370 37 37 I DEBUG : #24 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.370 37 37 I DEBUG : #25 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.370 37 37 I DEBUG : #26 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.379 37 37 I DEBUG : #27 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.379 37 37 I DEBUG : #28 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.379 37 37 I DEBUG : #29 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.379 37 37 I DEBUG : #30 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.389 37 37 I DEBUG : #31 pc 0001ef9c /system/lib/libc.so (exit)
20:56:43 INFO - 05-06 03:55:28.389 37 37 I DEBUG :
20:56:43 INFO - 05-06 03:55:28.389 37 37 I DEBUG : code around pc:
20:56:43 INFO - 05-06 03:55:28.389 37 37 I DEBUG : 00000000 ffffffff ffffffff ffffffff ffffffff ................
20:56:43 INFO - 05-06 03:55:28.389 37 37 I DEBUG : 00000010 ffffffff ffffffff ffffffff ffffffff ................
20:56:43 INFO - 05-06 03:55:28.389 37 37 I DEBUG : 00000020 ffffffff ffffffff ffffffff ffffffff ................
20:56:43 INFO - 05-06 03:55:28.399 37 37 I DEBUG : 00000030 ffffffff ffffffff ffffffff ffffffff ................
20:56:43 INFO - 05-06 03:55:28.399 37 37 I DEBUG : 00000040 ffffffff ffffffff ffffffff ffffffff ................
20:56:43 INFO - 05-06 03:55:28.399 37 37 I DEBUG :
20:56:43 INFO - 05-06 03:55:28.399 37 37 I DEBUG : code around lr:
20:56:43 INFO - 05-06 03:55:28.399 37 37 I DEBUG : 40d6ebf0 013a1f86 017a2356 69c3b570 f8d34604 ..:.V#z.p..i.F..
20:56:43 INFO - 05-06 03:55:28.399 37 37 I DEBUG : 40d6ec00 b1291108 20004b0a 681b447b 4798691b ..)..K. {D.h.i.G
20:56:43 INFO - 05-06 03:55:28.399 37 37 I DEBUG : 40d6ec10 f7ff4620 69e3ff25 1108f8d3 b1294605 F..%..i.....F).
20:56:43 INFO - 05-06 03:55:28.399 37 37 I DEBUG : 40d6ec20 20004b04 681b447b 4798695b bd704628 .K. {D.h[i.G(Fp.
20:56:43 INFO - 05-06 03:55:28.409 37 37 I DEBUG : 40d6ec30 01799f5c 01799f40 4ff0e92d 4604b095 \.y.@.y.-..O...F
20:56:43 INFO - 05-06 03:55:28.409 37 37 I DEBUG :
20:56:43 INFO - 05-06 03:55:28.409 37 37 I DEBUG : stack:
20:56:43 INFO - 05-06 03:55:28.409 37 37 I DEBUG : beafea20 43d00000
20:56:43 INFO - 05-06 03:55:28.409 37 37 I DEBUG : beafea24 00000007
20:56:43 INFO - 05-06 03:55:28.409 37 37 I DEBUG : beafea28 400b5044
20:56:43 INFO - 05-06 03:55:28.419 37 37 I DEBUG : beafea2c 400180eb /system/b2g/libmozglue.so
20:56:43 INFO - 05-06 03:55:28.419 37 37 I DEBUG : beafea30 43d41000
20:56:43 INFO - 05-06 03:55:28.419 37 37 I DEBUG : beafea34 40019bad /system/b2g/libmozglue.so
20:56:43 INFO - 05-06 03:55:28.419 37 37 I DEBUG : beafea38 00000000
20:56:43 INFO - 05-06 03:55:28.419 37 37 I DEBUG : beafea3c 43db0014
20:56:43 INFO - 05-06 03:55:28.419 37 37 I DEBUG : beafea40 43d41800
20:56:43 INFO - 05-06 03:55:28.419 37 37 I DEBUG : beafea44 42510754 /system/b2g/libxul.so
20:56:43 INFO - 05-06 03:55:28.429 37 37 I DEBUG : beafea48 00000004
20:56:43 INFO - 05-06 03:55:28.429 37 37 I DEBUG : beafea4c 00001000
20:56:43 INFO - 05-06 03:55:28.429 37 37 I DEBUG : beafea50 00000000
20:56:43 INFO - 05-06 03:55:28.429 37 37 I DEBUG : beafea54 42511630
20:56:43 INFO - 05-06 03:55:28.429 37 37 I DEBUG : beafea58 df0027ad
20:56:43 INFO - 05-06 03:55:28.429 37 37 I DEBUG : beafea5c 00000000
20:56:43 INFO - 05-06 03:55:28.429 37 37 I DEBUG : #01 beafea60 43d8d240
20:56:43 INFO - 05-06 03:55:28.439 37 37 I DEBUG : beafea64 42510754 /system/b2g/libxul.so
20:56:43 INFO - 05-06 03:55:28.439 37 37 I DEBUG : beafea68 43db0014
20:56:43 INFO - 05-06 03:55:28.439 37 37 I DEBUG : beafea6c 40d717ed /system/b2g/libxul.so
20:56:43 INFO - 05-06 03:55:33.730 33 33 I ServiceManager: service 'media.resource_manager' died
20:56:43 INFO - 05-06 03:55:33.730 33 33 I ServiceManager: service 'permission' died
20:56:43 INFO - Return code: 0
20:56:43 INFO - Copying /builds/slave/test/build/emulator-5554.log to /builds/slave/test/build/blobber_upload_dir/emulator-5554.log
20:56:43 INFO - Copying /builds/slave/test/build/qemu.log to /builds/slave/test/build/blobber_upload_dir/qemu.log
20:56:43 INFO - TinderboxPrint: mochitest<br/>33360/<em class="testfail">5</em>/64
20:56:43 WARNING - # TBPL WARNING #
20:56:43 WARNING - The mochitest suite: mochitest-1 ran with return status: WARNING
20:56:43 INFO - Running post-action listener: _resource_record_post_action
20:56:43 INFO - Running post-run listener: _resource_record_post_run
20:56:44 INFO - Total resource usage - Wall time: 1592s; CPU: 95.0%; Read bytes: 34271232; Write bytes: 383442944; Read time: 21048; Write time: 1795268
20:56:44 INFO - install - Wall time: 0s; CPU: Can't collect data; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
20:56:44 INFO - run-tests - Wall time: 1592s; CPU: 95.0%; Read bytes: 30961664; Write bytes: 383442944; Read time: 20516; Write time: 1795268
20:56:44 INFO - Running post-run listener: _upload_blobber_files
20:56:44 INFO - Blob upload gear active.
20:56:44 INFO - Preparing to upload files from /builds/slave/test/build/blobber_upload_dir.
20:56:44 INFO - Files from /builds/slave/test/build/blobber_upload_dir are to be uploaded with <try> branch at the following location(s): https://blobupload.elasticbeanstalk.com
20:56:44 INFO - Running command: ['/builds/slave/test/build/venv/bin/python', '/builds/slave/test/build/venv/bin/blobberc.py', '-u', 'https://blobupload.elasticbeanstalk.com', '-a', '/builds/slave/test/oauth.txt', '-b', 'try', '-d', '/builds/slave/test/build/blobber_upload_dir']
20:56:44 INFO - Copy/paste: /builds/slave/test/build/venv/bin/python /builds/slave/test/build/venv/bin/blobberc.py -u https://blobupload.elasticbeanstalk.com -a /builds/slave/test/oauth.txt -b try -d /builds/slave/test/build/blobber_upload_dir
20:56:44 INFO - (blobuploader) - INFO - Open directory for files ...
20:56:44 INFO - (blobuploader) - INFO - Uploading /builds/slave/test/build/blobber_upload_dir/qemu.log ...
20:56:44 INFO - (blobuploader) - INFO - Using https://blobupload.elasticbeanstalk.com
20:56:44 INFO - (blobuploader) - INFO - Uploading, attempt #1.
20:56:45 INFO - (blobuploader) - INFO - TinderboxPrint: <a href='http://mozilla-releng-blobs.s3.amazonaws.com/blobs/try/sha512/b1a9cb1ad1243e227225372cb6fa0fb85589f9bc73cbc914c1b9d256098bddeb33474732263e6a35311d69992483e99b021043c4c47fc75e8be24faea175d556'>qemu.log</a>: uploaded
20:56:45 INFO - (blobuploader) - INFO - Blobserver returned 202. File uploaded!
20:56:45 INFO - (blobuploader) - INFO - Done attempting.
20:56:45 INFO - (blobuploader) - INFO - Uploading /builds/slave/test/build/blobber_upload_dir/emulator-5554.log ...
20:56:45 INFO - (blobuploader) - INFO - Using https://blobupload.elasticbeanstalk.com
20:56:45 INFO - (blobuploader) - INFO - Uploading, attempt #1.
20:56:47 INFO - (blobuploader) - INFO - TinderboxPrint: <a href='http://mozilla-releng-blobs.s3.amazonaws.com/blobs/try/sha512/c731af63984858a13198cb787bb69a6e32456c5763db2a2c93a0519a9754622b5a8473510dc8901204ed5cd1e44a461850bb809e478ae8de19447677599e4378'>emulator-5554.log</a>: uploaded
20:56:47 INFO - (blobuploader) - INFO - Blobserver returned 202. File uploaded!
20:56:47 INFO - (blobuploader) - INFO - Done attempting.
20:56:47 INFO - (blobuploader) - INFO - Iteration through files over.
20:56:47 INFO - Return code: 0
20:56:47 INFO - Copying logs to upload dir...
Reporter | ||
Comment 1•10 years ago
|
||
I forgot to mention that this problem only occurs on:
B2G ICS Emulator Opt on TBPL.
Reporter | ||
Comment 2•10 years ago
|
||
Seems like the same problem: https://bugzilla.mozilla.org/show_bug.cgi?id=978926
Reporter | ||
Comment 3•10 years ago
|
||
Apparently AsyncOpen was failing on B2G ICS Emulator when sending reports in test_bug836922_npolicies.html which caused the test to fail.
In particular:
nsCSPContext::SendReports called AsyncOpen, which called
HttpChannelChild::AsyncOpen (MissingRequiredTabChild(tabChild, "http")), which called
MissingRequiredTabChild (UsingNeckoIPCSecurity()), which returned false.
The problem can be resolved by setting |network.disable.ipc.security| to true, which is what I did in the attached patch. Why this is causing a problem only when using the new implementation of CSP and not the old one, I can't really tell. In my opinion, test_bug836922_npolicies.html should fail either using the new, or the old CSP implementation when |security.csp.speccompliant| is set to true.
Sid, can you reason why this error occurs only when using the new implementation? Are we creating/using/consuming channels differently in the new C++ CSP implementation? Do you think we should just switch the flag so the tests passes, or do we have to digg deeper here?
Flags: needinfo?(sstamm)
Comment 4•10 years ago
|
||
The obvious difference is javascript. Maybe xpconnect or the gc is taking care of some things for us that we don't get with the new implementation in C++ (like longer-lived objects in JS due to gc not running or wrapper help). Networking on B2G isn't something I'm very familiar with, sorry.
Jason: do you have any idea what's going on here?
Flags: needinfo?(sstamm) → needinfo?(jduell.mcbugs)
Comment 5•10 years ago
|
||
> The problem can be resolved by setting |network.disable.ipc.security| to true,
> which is what I did in the attached patch. Why this is causing a problem only
> when using the new implementation of CSP and not the old one, I can't really
> tell.
Necko channels in e10s require the all channels have channel.notificationCallbacks set, and that the notificationCallbacks can GetInterface() to a nsITabChild. This is what gives us the TabChild/TabParent that lets us verify that an app is really the app that it says it is. If you're missing that, you get the error message you see.
What's almost certainly going on is that the new code is not setting the callbacks property. You need to find the relevant TabChild (IIRC the docshell?) and set it as the callbacks.
Flags: needinfo?(jduell.mcbugs)
Reporter | ||
Comment 6•10 years ago
|
||
First, thanks jduell for your help, comment 5 gave the best hint and in the end fixed the problem.
Providing a patch which fixes the problem where AsyncOpen can not query the iTabChild in B2G. Initially I tried to use an nsCOMPtr storing the channel in setRequestContext, but that led to memory leaks, similar to the problem we where experienced with the principal in bug 994466.
Using a weakPtr for the channel also did not work, because it was cleaned up and ended up beeing a nullptr. Therefore I ended up just storing the loadGroup from the channel set in SetRequestContext. Turns out to work just fine and exactly what we want in the end. No memory leaks, all tests pass.
Sid, since bug 994322 hasn't landed yet, should we incorporated the provided patch there or should we leave it here. In case we leave the patch with this bug, both bugs (994322 and this one) have to land at the same time.
In case we go down that route and use the provided patch we would also have to slightly modify TestCSPParser, which currently does not provide a channel when calling setRequestContext.
Flags: needinfo?(sstamm)
Reporter | ||
Updated•10 years ago
|
Attachment #8421319 -
Attachment is obsolete: true
Comment 7•10 years ago
|
||
Yeah, lets roll this small fix into bug 994322's patch, since it should really be part of that work anyway. Thanks guys for figuring this out!
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(sstamm)
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•