Closed
Bug 1006620
Opened 11 years ago
Closed 11 years ago
[tarako] Marketplace doesn't load in any language other than english
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mat, Assigned: robhudson)
References
Details
At least with the app manager (so, not a real package, but close), yogafire seems broken for languages other than english.
STR:
- Checkout yogafire, run make_package_prod
- Point the app manager to the package directory (/path/to/yogafire/package/archives/latest_prod)
- Set up your phone in french or some language we support
- Hit update and then debug
Expected results:
- Marketplace loaded in french
Actual results:
- Marketplace never loads. In the console, I can see:
"[amd] Error initializing module: " "content-ratings" include.js:3
"[amd] Error initializing dependencies: " "views/app" include.js:3
"[amd] Error initializing dependencies: " "routes" include.js:3
"[amd] Error initializing dependencies: " "views" include.js:3
"[amd] Error initializing dependencies: " "navigation" include.js:3
"[amd] Error initializing dependencies: " "tracking_helpers" include.js:3
"[amd] Error initializing dependencies: " "buttons" include.js:3
"[amd] Error initializing dependencies: " "marketplace"
require('l10n') works fine.
require('content-ratings') gives:
TypeError: e.navigator.l10n is undefined
"[amd] Error initializing module: " "content-ratings"
I tried pushing l10n.js to the top of the dependencies list in marketplace module, but that didn't help. Not sure what's going on.
Assignee | ||
Comment 1•11 years ago
|
||
Fixed in https://github.com/mozilla/yogafire/commit/bb781fdb
2 things were wrong:
1) The locales weren't being generated.
2) The l10n.js script was looking for the locales in the wrong directory.
Assignee: nobody → robhudson.mozbugs
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 2•11 years ago
|
||
Doesn't seem to be working for me.
With "hi-IN" language (second from the language list on my tarako device), launched updated yogafire using STR above and I still get the same error.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 3•11 years ago
|
||
Bumped commonplace to fix it : https://github.com/mozilla/yogafire/commit/86d98ae9fb843564c1b05ee5efd1428f3a08c077
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Comment 4•10 years ago
|
||
Tarako marketplace loads in Hindi, Bengali (caveat: bug 1012799) and Tamil.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•