Closed
Bug 1006692
Opened 11 years ago
Closed 11 years ago
Remove nsScriptSecurityManager::SubjectIsPrivileged and AccessCheck::IsCallerChrome
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: bholley, Assigned: jlevesy)
References
Details
(Whiteboard: [mentor=bholley,lang=c++])
Attachments
(1 file)
(deleted),
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
With bug 997987, these can now just go through nsContentUtils::IsCallerChrome().
Assignee | ||
Comment 1•11 years ago
|
||
Here's a first attempt.
It builds, but I didn't tested it. Actually I don't know which test suite I have to run to valitate this patch.
Thanks for review :-) !
Reporter | ||
Comment 2•11 years ago
|
||
Comment on attachment 8425053 [details] [diff] [review]
Patchv1
Thanks for the patch! In the future, you should set the 'review?' flag to someone appropriate to make sure that the patch doesn't get lost. I'll look at it now. :-)
Attachment #8425053 -
Flags: review?(bobbyholley)
Reporter | ||
Comment 3•11 years ago
|
||
Comment on attachment 8425053 [details] [diff] [review]
Patchv1
Review of attachment 8425053 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good! I think a try push with the following parameters should suffice:
try: -b do -p linux64 -u all -t none
Let me know if you need someone to push this to try for you. :-)
Attachment #8425053 -
Flags: review?(bobbyholley) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Oops, I didn't see your answer.
Sorry about that.
Actually I don't think I have the rights to make a try push.
I'm a quite new contributor :)
So, could you push this for me ?
Thanks !
Reporter | ||
Comment 5•11 years ago
|
||
Reporter | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 6•11 years ago
|
||
checkedin - Julien, welcome and thanks for contributing to mozilla!
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc4c4e5fe01d
Assignee: nobody → jlevesy
Keywords: checkin-needed
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•