Closed
Bug 1007050
Opened 11 years ago
Closed 9 years ago
backout bug 888159 since VS2013RTM supports std::isinf etc
Categories
(Core :: MFBT, defect)
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
Bug 888159 occured on VS2013 pre-release version. But I test on RTM and Update 1, it doesn't occur. We should backout bug 888159 (changeset 779c32741707).
|
Assignee | |
Comment 1•9 years ago
|
||
Assignee: nobody → m_kato
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8637017 [details] [diff] [review]
Remove MSVS workaround
This ifdef is a workaround for VS2013 re-release version. But this is already fixed by VS 2013 RTM and later.
Attachment #8637017 -
Flags: review?(jwalden+bmo)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8637017 [details] [diff] [review]
Remove MSVS workaround
Review of attachment 8637017 [details] [diff] [review]:
-----------------------------------------------------------------
::: mfbt/decimal/moz-decimal-utils.h
@@ -38,5 @@
> ClassName(const ClassName&) = delete; \
> void operator=(const ClassName&) = delete;
>
> -#if defined(_MSC_VER)
> -namespace std {
Hmm, I guess we're saved on redefinitions by these being ODR-equivalent and all. Fine by me removing it, but I won't be surprised if someone ends up being mildly grumpy their pre-release MSVC stopped working.
Attachment #8637017 -
Flags: review?(jwalden+bmo) → review+
|
||
Comment 5•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•