Closed Bug 1007367 Opened 11 years ago Closed 10 years ago

[appmgr v2] Debug Main Process needs to be ported over

Categories

(DevTools Graveyard :: WebIDE, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 34

People

(Reporter: jryans, Assigned: paul)

References

Details

Attachments

(3 files)

AMv2 currently doesn't have the "Debug Main Process" button.
We need to be able to debug a target that is not a runtime app. But we can't add a 4th target type in WebIDE. So we need bug 1023081 to get fixed first.
Depends on: 1023081
Attached patch v0.1 (deleted) — Splinter Review
Ryan, the right way to fix this bug is to fix bug 1023081 first. But I'm not sure I'll have the time to fix it in time for Fx 34. And we can't enable WebIDE without main process debugging. So here we are, ugly-patch-that-works.
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #8464652 - Flags: feedback?(jryans)
No longer depends on: 1023081
Comment on attachment 8464652 [details] [diff] [review] v0.1 Review of attachment 8464652 [details] [diff] [review]: ----------------------------------------------------------------- Well, it is bit hacky as you say, but I agree we really need this. I frequently revert to App Manager to use this feature. ::: browser/devtools/webide/content/details.js @@ +87,5 @@ > document.querySelector("#type").textContent = manifest.type || "web"; > document.querySelector("#manifestURLHeader").classList.remove("hidden"); > document.querySelector("#manifestURL").textContent = manifest; > + } else if (project.type == "mainProcess") { > + document.querySelector("#type").textContent = "main process"; Should this and all the other places you display "main process" to the user be translated strings? Or should we assume non-native English speakers understand "main process"? ::: browser/devtools/webide/content/webide.js @@ +830,5 @@ > + if (AppManager.connection.status == Connection.Status.CONNECTED && > + Services.prefs.getBoolPref("devtools.chrome.enabled")) { > + let panelItemNode = document.createElement("toolbarbutton"); > + panelItemNode.className = "panel-item"; > + panelItemNode.setAttribute("label", "main process"); This should at least say "Main Process", not "main process".
Attachment #8464652 - Flags: feedback?(jryans) → feedback+
Attached patch v1 (deleted) — Splinter Review
Attachment #8465296 - Flags: review?(jryans)
Attachment #8465296 - Flags: review?(jryans) → review+
Do we really need to check the devtools.chrome.enable pref?
This preference is only making the job harder for Gaia and B2G developers. Let's no hide "Main Process" when it's available.
Attachment #8465545 - Flags: review?(jryans)
Comment on attachment 8465545 [details] [diff] [review] don't check devtools.chrome.enable Review of attachment 8465545 [details] [diff] [review]: ----------------------------------------------------------------- This seems fine to me, checking this pref was a little weird anyway.
Attachment #8465545 - Flags: review?(jryans) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
Paul, what would you suggest needs to be done to test this feature? Check that the button exists and is clickable and something happens, or some deeper test? Thanks.
Flags: qe-verify+
Flags: needinfo?(paul)
(In reply to Liz Henry :lizzard from comment #10) > Paul, what would you suggest needs to be done to test this feature? Check > that the button exists and is clickable and something happens, or some > deeper test? Thanks. 1) connect a device with certified app debugging enabled: https://developer.mozilla.org/en-US/docs/Tools/WebIDE#Debugging_certified_apps 2) see if in the project panel (button on the left) shows the "main process" button 3) click 4) debug 5) see if the inspector shows some nodes
Flags: needinfo?(paul)
Verified as fixed using Aurora 34.0a2 (20140917004003) under Win 7 64-bit, Ubuntu 12.10 32-bit and Mac OSX 10.9.4. The Main Process can be debugged for all simulators: 1.3, 1.4, 2.0 and 2.1. 2.1 simulator screen is blank in Ubuntu, but everything works otherwise. Considering that it is still unstable, let me know if I should investigate this issue further. Also, should I check this on a device too in order to mark this bug as verified?
QA Contact: petruta.rasa
I am pretty sure it works on a device, as I've used it there before. Please file a new issue for the simulator. Also, 2.2 simulator was just released, so it may be interesting to see if the issue is still there. We've had others report issues with the Linux simulators, but we haven't yet been able to find the root cause.
Flags: needinfo?(petruta.rasa)
Marking this as verified based on above comments. I uninstalled 2.1 simulator and it worked well after reinstall. The issue is now present for 2.2 simulator. I'll continue investigating and file a bug on Monday.
Flags: needinfo?(petruta.rasa)
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: