Closed
Bug 1007734
Opened 11 years ago
Closed 11 years ago
UpdatePanZoomControllerTree() could leave an APZC with a stale parent pointer
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: botond, Assigned: botond)
Details
Attachments
(1 file)
|
(deleted),
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
Quoting Kats from https://bugzilla.mozilla.org/show_bug.cgi?id=961289#c73
"It occurs to me that in the case where the apzc is recycled (i.e. code flow didn't take the |if (newApzc)| branch above) and also we go through the |mRootApzc = apzc| branch, then it's possible for apzc->GetParent() to be some stale pointer. I don't think this ever happens in practice but maybe we should explicitly null out the parent pointer when setting mRootApzc to apzc."
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → botond
Attachment #8419503 -
Flags: review?(bugmail.mozilla)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8419503 [details] [diff] [review]
bug1007734.patch
Review of attachment 8419503 [details] [diff] [review]:
-----------------------------------------------------------------
Nice! :)
Attachment #8419503 -
Flags: review?(bugmail.mozilla) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Updated•11 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•11 years ago
|
||
| green try | ||
|
|
Assignee | |
Comment 4•11 years ago
|
||
Try push is green but inbound is still (or again) closed, re-flagging as checkin-needed.
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
Keywords: checkin-needed
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•