Closed
Bug 1007988
Opened 11 years ago
Closed 10 years ago
Searching through about:home should add searches to searchbar-history
Categories
(Firefox :: Search, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mconnor, Assigned: mconnor)
References
Details
Attachments
(1 file)
(deleted),
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
In the process of implementing bug 612453, I realized that we don't actually add searches to the searchbar history, which feels like an easy/obvious fix, especially if we're going to use local results in about:home! I've modified the code from search.xml, but I'm using FormHistory.jsm directly.
Attachment #8419796 -
Flags: review?(MattN+bmo)
Comment 1•11 years ago
|
||
Comment on attachment 8419796 [details] [diff] [review] addAboutHomeSearchesToFormHistory Review of attachment 8419796 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. Note that I'm on vacation until Monday (inclusive) so I won't get to the other search bugs until after that A test for this would be nice since it's a special case that is easy to overlook in manual testing. I believe you know about this but FYI just in case: https://mxr.mozilla.org/mozilla-central/source/toolkit/components/satchel/nsFormAutoComplete.js?rev=669dff46362f#171
Attachment #8419796 -
Flags: review?(MattN+bmo) → review+
Comment 2•10 years ago
|
||
This was fixed by bug 612453, but note bug 1060845.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•