Closed
Bug 1008248
Opened 11 years ago
Closed 10 years ago
Split shared headers.css into building-block and web-component stylesheets
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S2 (23may)
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | fixed |
People
(Reporter: wilsonpage, Assigned: arnau)
References
Details
Attachments
(1 file)
Currently `shared/style/headers.css` is supporting both old building blocks and new web-components header styling. We should create a dedicated gaia-header.css to style just the new <gaia-header> element.
Arnau- let me know if you have time to take a look at this.
Assignee: nobody → arnau
Assignee | ||
Comment 2•10 years ago
|
||
(In reply to jachen from comment #1) > Arnau- let me know if you have time to take a look at this. Sure, no problem.
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8424890 [details]
patch in github
Only time for a quick scan, but looks good at first glance. Couple of issues/queries:
- Why are there icon PNGs for actions that aren't configurable (eg. send.png, compose.png). I owuld have thought it was the component user's job to bring along these kind of assets.
- Not sure why we still need <header> in the template.
Attachment #8424890 -
Flags: review?(wilsonpage) → review+
Assignee | ||
Comment 5•10 years ago
|
||
PNGs are there because some app owners decided to move those icons used in several apps, as a way to have them centralized and easier to update. We will be able to remove them from the component when we support icon fonts :) I'm using <header> in the template as a container to duplicate attributes like skin, so children get the right styles.
Assignee | ||
Updated•10 years ago
|
Blocks: gaia-header
Assignee | ||
Comment 6•10 years ago
|
||
Merged: e6548220ac8034c1952419aaab6db6c2de25c899
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
status-b2g-v2.0:
--- → fixed
Target Milestone: --- → 2.0 S2 (23may)
You need to log in
before you can comment on or make changes to this bug.
Description
•