STR: 1. Go to http://todomvc.com/architecture-examples/backbone/ 2. Open debugger 3. Add a breakpoint on line 27 of app-view.js 4. Breakpoint slides to line 30 5. Click again on line 27 6. Click on line 30 Breakpoint doesn't get removed again. Unlike bug 1008372, the breakpoint does go away after reloading the page.

Confirmed.

The link referred to in step 1 no longer exists, so the steps to reproduce are no longer valid. Without steps to reproduce, this bug is not actionable, so I'm closing it until further notice. If anyone can come up with up-to-date steps to reproduce, feel free to reopen this bug, or open a new one.

301 http://todomvc.com/examples/backbone/, I presume?

(In reply to Jonathan Allard from comment #3) > 301 http://todomvc.com/examples/backbone/, I presume? Thanks a lot, Jonathan. I can indeed reproduce the bug, using the link you provided. This looks like a frontend problem. The breakpoint does not disappear in the editor, but it does disappear in the sources view. I'll take a shot at this tomorrow.

This is pretty annoying.

The problem seems to be that when the breakpoint has an actual location that differs from the requested location, we remove the 'added; promise for the requested location, and re-add it at the actual location, even when we already have a breakpoint for the actual location. This confuses the editor, because certain things end up being done twice for the same breakpoint. The solution is to check if we already have an 'added' promise for the actual location, and if so, to just return that. I've also removed requestedLocation, because its only ever used in one place, and it fits better in addBreakpoint anyway, so its not necessary.

Comment on attachment 8599279 [details] [diff] [review] patch Review of attachment 8599279 [details] [diff] [review]: ----------------------------------------------------------------- This change makes sense, thanks!

Try fun for this patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd1d468bd0a9

Try run looks almost good. Just forgot to update a test. Here's a second try run with that problem addressed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=35a783d757e9

don't forget to land this :)

needinfo'ing Eddy. This needs to land asap, Wed at the latest.

Argh. I keep forgetting about this bug. Being preoccupied with worker debugging. I'll land this first thing in the morning. Sorry Jeff!

Backed out for browser_dbg_breakpoints-actual-location.js failures. https://treeherder.mozilla.org/logviewer.html#?job_id=3314202&repo=fx-team https://hg.mozilla.org/integration/fx-team/rev/70fa9da159a0