Closed
Bug 1008668
Opened 11 years ago
Closed 11 years ago
Make Qt port compile on 5.0.2
Categories
(Core Graveyard :: Widget: Qt, defect)
Core Graveyard
Widget: Qt
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla32
People
(Reporter: evilpie, Assigned: evilpie)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
romaxa
:
review-
|
Details | Diff | Splinter Review |
My distribution ships with Qt 5.0.2, but QWindow::setVisibility was introduced in 5.1. As this seems to be to only thing blocking it, we should ifdef it.
Attachment #8420625 -
Flags: review?(romaxa)
|
||
Updated•11 years ago
|
Attachment #8420625 -
Flags: review?(romaxa) → review+
|
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8420625 [details] [diff] [review]
visibility
Actually setVisibility(Hidden) is just wrapper around QWindow::hide
Could you check if widget->hide() works for you under Qt 5.0.2 ?
Also please add this into patch header:
# User Tom Schuster <evilpies@gmail.com>
Bug 1008668 - Make Qt port compile on 5.0.2. r=romaxa
Attachment #8420625 -
Flags: review+ → review-
|
Assignee | |
Comment 2•11 years ago
|
||
That compiles, but there is still a 1x1 window created with the title "firefox". When I maximize it, it seems to contain about:home?
|
|
||
Comment 3•11 years ago
|
||
I believe that is different issue,make sense to check Resize calls.
Probably I don't see that because I have tiled window manager with fixed window frames.
File another bug for that problem
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•