Closed
Bug 1009334
Opened 10 years ago
Closed 10 years ago
Ship the bootstrap.js file with Firefox
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla32
People
(Reporter: evold, Assigned: evold)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Hey,
Do either of you two have some ideas about how best to do this?
At the moment my patch in bug 915376 just has a copy of the bootstrap.js from the add-on sdk repo, but I doubt that we want to land that way. We should be able to make updates to the bootstrap.js file from the addon-sdk repo instead of having to do them in m-c
Comment 2•10 years ago
|
||
All of our modules are copied into the build to be under resource://gre/modules/commonjs... If we copied the bootstrap somewhere similar then the add-on manager can load it from there like it does for the dictionary bootstrap script.
Flags: needinfo?(dtownsend+bugmail)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → evold
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Dave Townsend [:mossop] from comment #2)
> All of our modules are copied into the build to be under
> resource://gre/modules/commonjs... If we copied the bootstrap somewhere
> similar then the add-on manager can load it from there like it does for the
> dictionary bootstrap script.
ok I see how this is done, with the copy_source.py file, should the file be located in `resource://gre/modules/commonjs/` or someplace else? like `resource://gre/modules/bootstraps/` ?
Flags: needinfo?(dtownsend+bugmail)
Comment 4•10 years ago
|
||
We have precedence for putting bootstraps into resource://gre/modules, just do it like this and give it an appropriate name (SDKBootstrap.js?): http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/internal/moz.build#16
Flags: needinfo?(dtownsend+bugmail)
Updated•10 years ago
|
Priority: -- → P1
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Dave Townsend [:mossop] from comment #4)
> We have precedence for putting bootstraps into resource://gre/modules, just
> do it like this and give it an appropriate name (SDKBootstrap.js?):
> http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/
> internal/moz.build#16
k that sounds good to me.
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8424175 -
Flags: review?(dtownsend+bugmail)
Assignee | ||
Comment 7•10 years ago
|
||
So it seems difficult to have the file copied & renamed, and renaming the file in the sdk would break a cfx use case where one copies the `app-extension` folder, makes changes, and uses `cfx --template-dir`. So my patch is moving the bootstrap.js file to resource://gre/modules/sdk/bootstrap.js
In the future we could use this directory for JSMs.
Assignee | ||
Comment 8•10 years ago
|
||
(In reply to Erik Vold [:erikvold] [:ztatic] from comment #7)
> So it seems difficult to have the file copied & renamed, and renaming the
> file in the sdk would break a cfx use case where one copies the
> `app-extension` folder, makes changes, and uses `cfx --template-dir`. So my
> patch is moving the bootstrap.js file to
> resource://gre/modules/sdk/bootstrap.js
oh for the record I know we'll break this at some point anyhow, but I'd prefer to wait until jpm is shipped.
Updated•10 years ago
|
Attachment #8424175 -
Flags: review?(dtownsend+bugmail) → review+
Assignee | ||
Comment 9•10 years ago
|
||
Comment 10•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/b744c9e6a26c9c5ea3c43a1969bacdee0e8089a6
Bug 1009334 - Ship the Add-on SDK bootstrap.js file with Firefox r=Mossop
Comment 11•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Updated•10 years ago
|
Flags: needinfo?(rFobic)
You need to log in
before you can comment on or make changes to this bug.
Description
•